[GitHub] [solr] Caa52 commented on a change in pull request #638: SOLR-12336: DocSetQuery can have 1 score

[GitBox <gi...@apache.org>]

Caa52 commented on a change in pull request #638:
URL: https://github.com/apache/solr/pull/638#discussion_r808332415



##########
File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java
##########
@@ -78,11 +78,9 @@ public DocSet createDocSet(SolrIndexSearcher searcher) throws IOException {
 
     @Override
     public Weight createWeight(IndexSearcher searcher, ScoreMode scoreMode, float boost) throws IOException {
-        //This should probably use the provided boost as scorer. However, that causes
-        // TestSolrQueryParser.testFilter to fail.
-        return new ConstantScoreWeight(this, 0) {
+        return new ConstantScoreWeight(this, boost) {

Review comment:
       When I attempted refactoring this like so, `TestSolrQueryParser.testFilter` was failing. Granted, I didn't make the changes in FilterQuery. I am not sure I completely follow why the test now passes after making the changes in FilterQuery. Please explain. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org