You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2024/10/16 12:02:01 UTC
[PR] IGNITE-23419 Advance Safe Time in KeyValueStorage#saveCompactionRevision [ignite-3]
tkalkirill opened a new pull request, #4575:
URL: https://github.com/apache/ignite-3/pull/4575
https://issues.apache.org/jira/browse/IGNITE-23419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23419 Advance Safe Time in KeyValueStorage#saveCompactionRevision [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #4575:
URL: https://github.com/apache/ignite-3/pull/4575#discussion_r1803571221
##########
modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/AbstractCompactionKeyValueStorageTest.java:
##########
@@ -109,6 +115,11 @@ void setUp() {
assertEquals(List.of(4, 6/* Tombstone */), collectRevisions(SOME_KEY));
}
+ @Override
Review Comment:
```suggestion
@AfterEach
@Override
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23419 Advance Safe Time in KeyValueStorage#saveCompactionRevision [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #4575:
URL: https://github.com/apache/ignite-3/pull/4575#discussion_r1804075462
##########
modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/AbstractCompactionKeyValueStorageTest.java:
##########
@@ -109,6 +115,11 @@ void setUp() {
assertEquals(List.of(4, 6/* Tombstone */), collectRevisions(SOME_KEY));
}
+ @Override
Review Comment:
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23419 Advance Safe Time in KeyValueStorage#saveCompactionRevision [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #4575:
URL: https://github.com/apache/ignite-3/pull/4575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23419 Advance Safe Time in KeyValueStorage#saveCompactionRevision [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on code in PR #4575:
URL: https://github.com/apache/ignite-3/pull/4575#discussion_r1803532737
##########
modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java:
##########
@@ -760,6 +772,14 @@ public void saveCompactionRevision(long revision) {
assertCompactionRevisionLessThanCurrent(revision, rev);
savedCompactionRevision = revision;
+
+ setIndexAndTerm(context.index, context.term);
+
+ if (!areWatchesEnabled) {
+ return;
+ }
+
+ watchProcessor.advanceSafeTime(context.timestamp);
Review Comment:
```suggestion
setIndexAndTerm(context.index, context.term);
if (areWatchesEnabled) {
watchProcessor.advanceSafeTime(context.timestamp);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23419 Advance Safe Time in KeyValueStorage#saveCompactionRevision [ignite-3]
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #4575:
URL: https://github.com/apache/ignite-3/pull/4575#discussion_r1804075737
##########
modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java:
##########
@@ -760,6 +772,14 @@ public void saveCompactionRevision(long revision) {
assertCompactionRevisionLessThanCurrent(revision, rev);
savedCompactionRevision = revision;
+
+ setIndexAndTerm(context.index, context.term);
+
+ if (!areWatchesEnabled) {
+ return;
+ }
+
+ watchProcessor.advanceSafeTime(context.timestamp);
Review Comment:
I'll leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23419 Advance Safe Time in KeyValueStorage#saveCompactionRevision [ignite-3]
Posted by "ivanzlenko (via GitHub)" <gi...@apache.org>.
ivanzlenko commented on PR #4575:
URL: https://github.com/apache/ignite-3/pull/4575#issuecomment-2418460183
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org