You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/07 11:04:54 UTC
[GitHub] [maven] KroArtem opened a new pull request #312: [MNG-6844] replace
string-defined charsets by StandardCharsets and remove unneeded suppressions
KroArtem opened a new pull request #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions
URL: https://github.com/apache/maven/pull/312
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] KroArtem commented on a change in pull request #312:
[MNG-6844] replace string-defined charsets by StandardCharsets and remove
unneeded suppressions
Posted by GitBox <gi...@apache.org>.
KroArtem commented on a change in pull request #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions
URL: https://github.com/apache/maven/pull/312#discussion_r363743171
##########
File path: maven-compat/src/test/java/org/apache/maven/repository/legacy/StringWagon.java
##########
@@ -72,14 +73,7 @@ public void fillInputData( InputData inputData )
resource.setContentLength( content.length() );
resource.setLastModified( System.currentTimeMillis() );
- try
- {
- inputData.setInputStream( new ByteArrayInputStream( content.getBytes( "UTF-8" ) ) );
- }
- catch ( UnsupportedEncodingException e )
- {
- throw new Error( "broken JVM", e );
- }
+ inputData.setInputStream( new ByteArrayInputStream( content.getBytes(StandardCharsets.UTF_8) ) );
Review comment:
That's strange, I've fixed it after running `clean verify`
Will fix a bit later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #312:
[MNG-6844] replace string-defined charsets by StandardCharsets and remove
unneeded suppressions
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions
URL: https://github.com/apache/maven/pull/312#discussion_r363715018
##########
File path: maven-compat/src/test/java/org/apache/maven/repository/legacy/StringWagon.java
##########
@@ -72,14 +73,7 @@ public void fillInputData( InputData inputData )
resource.setContentLength( content.length() );
resource.setLastModified( System.currentTimeMillis() );
- try
- {
- inputData.setInputStream( new ByteArrayInputStream( content.getBytes( "UTF-8" ) ) );
- }
- catch ( UnsupportedEncodingException e )
- {
- throw new Error( "broken JVM", e );
- }
+ inputData.setInputStream( new ByteArrayInputStream( content.getBytes(StandardCharsets.UTF_8) ) );
Review comment:
Formatting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] asfgit closed pull request #312: [MNG-6844] replace
string-defined charsets by StandardCharsets and remove unneeded suppressions
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions
URL: https://github.com/apache/maven/pull/312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] KroArtem commented on issue #312: [MNG-6844] replace
string-defined charsets by StandardCharsets and remove unneeded suppressions
Posted by GitBox <gi...@apache.org>.
KroArtem commented on issue #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions
URL: https://github.com/apache/maven/pull/312#issuecomment-572443404
@michael-o , done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on a change in pull request #312:
[MNG-6844] replace string-defined charsets by StandardCharsets and remove
unneeded suppressions
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions
URL: https://github.com/apache/maven/pull/312#discussion_r363715080
##########
File path: maven-core/src/test/java/org/apache/maven/project/ExtensionDescriptorBuilderTest.java
##########
@@ -61,14 +62,7 @@ protected void tearDown()
private InputStream toStream( String xml )
{
- try
- {
- return new ByteArrayInputStream( xml.getBytes( "UTF-8" ) );
- }
- catch ( UnsupportedEncodingException e )
- {
- throw new IllegalStateException( e );
- }
+ return new ByteArrayInputStream( xml.getBytes(StandardCharsets.UTF_8) );
Review comment:
Formatting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] KroArtem commented on a change in pull request #312:
[MNG-6844] replace string-defined charsets by StandardCharsets and remove
unneeded suppressions
Posted by GitBox <gi...@apache.org>.
KroArtem commented on a change in pull request #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions
URL: https://github.com/apache/maven/pull/312#discussion_r364178667
##########
File path: maven-compat/src/test/java/org/apache/maven/repository/legacy/StringWagon.java
##########
@@ -72,14 +73,7 @@ public void fillInputData( InputData inputData )
resource.setContentLength( content.length() );
resource.setLastModified( System.currentTimeMillis() );
- try
- {
- inputData.setInputStream( new ByteArrayInputStream( content.getBytes( "UTF-8" ) ) );
- }
- catch ( UnsupportedEncodingException e )
- {
- throw new Error( "broken JVM", e );
- }
+ inputData.setInputStream( new ByteArrayInputStream( content.getBytes(StandardCharsets.UTF_8) ) );
Review comment:
Actually checkstyle doesn't think current formatting violates something, but I've fixed what you said.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services