You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/08 13:20:32 UTC

[GitHub] [camel] rnetuka opened a new pull request #4846: [ENTESB-15117] Implement consumer priority in camel

rnetuka opened a new pull request #4846:
URL: https://github.com/apache/camel/pull/4846


   From donwstream: 
   A customer want to provide a way or option to implement consumer priority in _camel-amqp_ and _camel-jms_ components while using ActiveMQ Artemis. 
   
   The feature is described here:
   https://activemq.apache.org/components/artemis/documentation/latest/consumer-priority.html
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus closed pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
davsclaus closed pull request #4846:
URL: https://github.com/apache/camel/pull/4846


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] rnetuka commented on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
rnetuka commented on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-761002890


   I can move the changes to camel-activemq, but this needs to work also with ActiveMQ Artemis. Is there any special component for Artemis?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-764414119


   We do already have an artemisStreamingMode so it may be okay to rename this to artemisConsumerPriority, then it indicate its only for this broker.
   
   However one day it may be worth to have camel-artemis component that has only those additional options.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-756763320


   This seems to be an ActiveMQ only feature and therefore we cannot have it as first class in the component as its for general JMS.
   
   There is the camel-activemq component where such ActiveMQ only features can be implemented.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] rnetuka edited a comment on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
rnetuka edited a comment on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-761002890


   I'm not sure if consumer-priority works with (the old) ActiveMQ. The feature request was for Artemis, so I guess we can either implement it in camel-jms, or create a new camel component just for Artemis. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] rnetuka edited a comment on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
rnetuka edited a comment on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-761002890


   The consumer priority option works (most probably) only with Artemis, not the old ActiveMQ.
   
   Also, based on this docs: https://camel.apache.org/components/latest/activemq-component.html, Artemis users should use camel-jms


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-756763320


   This seems to be an ActiveMQ only feature and therefore we cannot have it as first class in the component as its for general JMS.
   
   There is the camel-activemq component where such ActiveMQ only features can be implemented.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] rnetuka edited a comment on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
rnetuka edited a comment on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-761002890


   I can move the changes to camel-activemq, but this needs to work also with ActiveMQ Artemis. Is there any special component for Artemis?
   
   Also, based on this docs: https://camel.apache.org/components/latest/activemq-component.html, Artemis users should use camel-jms


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus closed pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
davsclaus closed pull request #4846:
URL: https://github.com/apache/camel/pull/4846


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-764414119






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on pull request #4846: Implement consumer priority in camel

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4846:
URL: https://github.com/apache/camel/pull/4846#issuecomment-764420045


   So I am merging this and updating it. Then later we can consider the camel-artemis


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org