You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Haibo Chen (JIRA)" <ji...@apache.org> on 2018/06/11 18:23:00 UTC
[jira] [Commented] (YARN-8325) Miscellaneous QueueManager code
clean up
[ https://issues.apache.org/jira/browse/YARN-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508485#comment-16508485 ]
Haibo Chen commented on YARN-8325:
----------------------------------
[~snemeth] the patch no longer applies. Can you update it?
> Miscellaneous QueueManager code clean up
> ----------------------------------------
>
> Key: YARN-8325
> URL: https://issues.apache.org/jira/browse/YARN-8325
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Reporter: Haibo Chen
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-8325.001.patch
>
>
> getLeafQueue(String name, boolean create, boolean recomputeSteadyShares) and
> getLeafQueue(String name, boolean create, boolean recomputeSteadyShares), setChildResourceLimits() can be declared as private.
> ensureRootPrefix() should be static.
> The static LOG field should be private.
> The log in
> if (!parent.getPolicy().isChildPolicyAllowed(childPolicy)) {
> LOG.error("Can't create queue '" + queueName + "'.");
> return null;
> }
> can be improved by the specific reason, ie. the child scheduling policy is not allowed by that of its parent.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org