You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Koji Noguchi (JIRA)" <ji...@apache.org> on 2008/03/28 23:56:24 UTC
[jira] Created: (HADOOP-3127) rm /user//.Trash/____ only
moves it back to .Trash
rm /user/<username>/.Trash/____ only moves it back to .Trash
-------------------------------------------------------------
Key: HADOOP-3127
URL: https://issues.apache.org/jira/browse/HADOOP-3127
Project: Hadoop Core
Issue Type: Bug
Components: fs
Affects Versions: 0.16.1
Reporter: Koji Noguchi
Priority: Minor
In 0.15 or before, any dfs -rm call for files under Trash were deleted.
>From 0.16, it just renames it back to Trash.
In Trash.java:moveToTrash()
{noformat}
if (path.toString().startsWith(trash.toString()))
{noformat}
seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3127) rm /user//.Trash/____ only
moves it back to .Trash
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley reassigned HADOOP-3127:
-------------------------------------
Assignee: Brice Arnould
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Assignee: Brice Arnould
> Priority: Minor
> Attachments: fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3127) rm /user//.Trash/____
only moves it back to .Trash
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591755#action_12591755 ]
Hadoop QA commented on HADOOP-3127:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380774/fixInTrashDeletion.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2309/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2309/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2309/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2309/console
This message is automatically generated.
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Assignee: Brice Arnould
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: fixInTrashDeletion.patch, fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3127) rm /user//.Trash/____
only moves it back to .Trash
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589269#action_12589269 ]
Hadoop QA commented on HADOOP-3127:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380175/fixInTrashDeletion.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2242/console
This message is automatically generated.
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Priority: Minor
> Attachments: fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3127) rm /user//.Trash/____ only
moves it back to .Trash
Posted by "Brice Arnould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brice Arnould updated HADOOP-3127:
----------------------------------
Status: Patch Available (was: Open)
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.3, 0.16.2, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Assignee: Brice Arnould
> Priority: Minor
> Attachments: fixInTrashDeletion.patch, fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3127) rm /user//.Trash/____ only
moves it back to .Trash
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3127:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.18.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this with the slight change of using Path.makeQualified instead of string append. Thanks, Brice!
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Assignee: Brice Arnould
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: fixInTrashDeletion.patch, fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3127) rm /user//.Trash/____ only
moves it back to .Trash
Posted by "Brice Arnould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brice Arnould updated HADOOP-3127:
----------------------------------
Attachment: fixInTrashDeletion.patch
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Priority: Minor
> Attachments: fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3127) rm /user//.Trash/____ only
moves it back to .Trash
Posted by "Brice Arnould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brice Arnould updated HADOOP-3127:
----------------------------------
Affects Version/s: (was: 0.16.1)
0.18.0
0.17.0
0.16.3
0.16.2
Status: Patch Available (was: Open)
Here is a patch and a test for this bug... It's my first patch to Hadoop, I just hope it is OK
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Priority: Minor
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3127) rm /user//.Trash/____ only
moves it back to .Trash
Posted by "Brice Arnould (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brice Arnould updated HADOOP-3127:
----------------------------------
Attachment: fixInTrashDeletion.patch
Oops. Here is a second patch, without those spaces.
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Assignee: Brice Arnould
> Priority: Minor
> Attachments: fixInTrashDeletion.patch, fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3127) rm /user//.Trash/____
only moves it back to .Trash
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592018#action_12592018 ]
Hudson commented on HADOOP-3127:
--------------------------------
Integrated in Hadoop-trunk #469 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/469/])
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.2, 0.16.3, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Assignee: Brice Arnould
> Priority: Minor
> Fix For: 0.18.0
>
> Attachments: fixInTrashDeletion.patch, fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3127) rm /user//.Trash/____ only
moves it back to .Trash
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3127:
----------------------------------
Status: Open (was: Patch Available)
Brice,
You picked up some spurious whitespace changes in your patch. Can you please re-create your patch without them? Thanks! Other than that, it looks good.
> rm /user/<username>/.Trash/____ only moves it back to .Trash
> -------------------------------------------------------------
>
> Key: HADOOP-3127
> URL: https://issues.apache.org/jira/browse/HADOOP-3127
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.3, 0.16.2, 0.17.0, 0.18.0
> Reporter: Koji Noguchi
> Assignee: Brice Arnould
> Priority: Minor
> Attachments: fixInTrashDeletion.patch
>
>
> In 0.15 or before, any dfs -rm call for files under Trash were deleted.
> From 0.16, it just renames it back to Trash.
> In Trash.java:moveToTrash()
> {noformat}
> if (path.toString().startsWith(trash.toString()))
> {noformat}
> seems like trash.toString() is fully qualified, and path.toString() is not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.