You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/22 14:22:29 UTC

[GitHub] [nifi] CefBoud opened a new pull request #4680: added userGroupsFilterExpression to allow per user LDAP filters

CefBoud opened a new pull request #4680:
URL: https://github.com/apache/nifi/pull/4680


   Added a 'User Groups Filter Expression' property to the LdapUserGroupProvider's configuration in authorizers.xml. When set, this property retrieves each user's groups according to the filter expressed in it and by replacing '{}' with the user's DN. 
   
   This introduces the possibility of filters such as : "member:1.2.840.113556.1.4.1941:={}". For each user, a request will be made and will populate all his direct and indirect groups. 
   This property can also be used to map groups to users regardless of the presence of an attribute that links the user to the group or vice versa. As long as a group satisfies the filter, the user will be assigned to it.  The presence of '{}' (which is replaced by a user's DN) is optionnal. 
   
   The 'Group Search Base' property is used as the search base for each request but the 'User Group Name Attribute' property is not allowed when the new property is defined as it conflicts with it since they both rely on a user entry for group inference. 
   
   As mentionned in the JIRA issue, this property will offer more flexibility and will allow handling of nested groups which are necessary in Microsoft's AGDLP and other organizational security requirements. 
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   #### Description of PR
   
   _Enables X functionality; fixes bug NIFI-YYYY._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] CefBoud closed pull request #4680: added userGroupsFilterExpression to allow per user LDAP filters

Posted by GitBox <gi...@apache.org>.
CefBoud closed pull request #4680:
URL: https://github.com/apache/nifi/pull/4680


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org