You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rangadi (via GitHub)" <gi...@apache.org> on 2023/08/14 17:30:27 UTC
[GitHub] [spark] rangadi commented on a diff in pull request #42476: [SPARK-44794][CONNECT] Make Streaming Queries work with Connect's artifact management
rangadi commented on code in PR #42476:
URL: https://github.com/apache/spark/pull/42476#discussion_r1293766120
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala:
##########
@@ -204,7 +207,9 @@ abstract class StreamExecution(
// To fix call site like "run at <unknown>:0", we bridge the call site from the caller
// thread to this micro batch thread
sparkSession.sparkContext.setCallSite(callSite)
- runStream()
+ JobArtifactSet.withActiveJobArtifactState(jobArtifactState) {
Review Comment:
FYI: @JerryLead, @huanliwang-db: This is based on thread-locals. Will it be ok if there are multiple micro-batches are active on multiple threads?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org