[GitHub] [mina-sshd] archiecobbs commented on issue #370: ModifiableFileWatcher should watch for changes in BasicFileAttributes.fileKey()

["archiecobbs (via GitHub)" <gi...@apache.org>]

archiecobbs commented on issue #370:
URL: https://github.com/apache/mina-sshd/issues/370#issuecomment-1550376922

   > It probably should (at least if a file key is available). IIRC, on Windows there are no file keys. Not sure about other file systems.
   
   Agreed. Javadoc for `BasicAttributes.fileKey()` says:
   
   > Returns an object that uniquely identifies the given file, or null if a file key is not available.
   
   So the code just needs to treat "null" as a value like any other, and then everything will work - file keys will be used if available, otherwise if the platform doesn't support file keys then we will fallback gracefully to the existing logic.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org