You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Randgalt <gi...@git.apache.org> on 2015/08/24 19:33:12 UTC
[GitHub] curator pull request: [CURATOR-248] Introduce pluggable error hand...
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/98
[CURATOR-248] Introduce pluggable error handlers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit 45df7ba71f14a5f9751061a7dff956312bfdd421
Author: randgalt <ra...@apache.org>
Date: 2015-08-24T17:24:06Z
Initial error policy with two implementations. Also, applied it to LeaderSelector as a test
commit 2e1e92e162ef812a9d076695500f0bda8b15b6c5
Author: randgalt <ra...@apache.org>
Date: 2015-08-24T17:30:33Z
doc
commit 94dff8a5a2ec336a23c05ebe5cdf7e4b117d3925
Author: randgalt <ra...@apache.org>
Date: 2015-08-24T17:31:52Z
Added since tags
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-248] Introduce pluggable error hand...
Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the pull request:
https://github.com/apache/curator/pull/98#issuecomment-138130903
Looks good to me Jordan. My only nit would be that the name ErrorPolicy doesn't really convey what it's an error policy. Would ConnectionStateErrorPolicy or something like that be more descriptive?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-248] Introduce pluggable error hand...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/98#issuecomment-138131587
I'm OK with renaming it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-248] Introduce pluggable error hand...
Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on the pull request:
https://github.com/apache/curator/pull/98#issuecomment-134404404
This is now feature complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] curator pull request: [CURATOR-248] Introduce pluggable error hand...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---