You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ne...@apache.org on 2020/11/28 20:28:20 UTC
[arrow] branch master updated: ARROW-10757: [Rust] [CI] Fix CI
failures
This is an automated email from the ASF dual-hosted git repository.
nevime pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new c384fe3 ARROW-10757: [Rust] [CI] Fix CI failures
c384fe3 is described below
commit c384fe3430cad299f4bd414fa8259816a563f868
Author: Neville Dipale <ne...@gmail.com>
AuthorDate: Sat Nov 28 22:26:59 2020 +0200
ARROW-10757: [Rust] [CI] Fix CI failures
Fixes Ci failures by separating running tests, and discarding artefacts after testing
Also adds a separate test for `arrow` on stable.
Changes made:
* Reorder the Rust tests to test other modules without `arrow`, reducing test duplication
* Add stable toolchain test for the `arrow` crate, test it next to `feature "simd"`
* Clear the test artefacts before testing `arrow`, to reclaim some disk space
* Update nightly to `2020-11-24` so that the tests would get triggered
Closes #8793 from nevi-me/ARROW-10757
Authored-by: Neville Dipale <ne...@gmail.com>
Signed-off-by: Neville Dipale <ne...@gmail.com>
---
.env | 2 +-
.github/workflows/rust.yml | 6 +++---
.github/workflows/rust_cron.yml | 2 +-
ci/docker/debian-10-rust.dockerfile | 5 +++--
ci/scripts/rust_test.sh | 24 ++++++++++++++----------
rust/rust-toolchain | 2 +-
6 files changed, 23 insertions(+), 18 deletions(-)
diff --git a/.env b/.env
index 56cd767..603f3ca 100644
--- a/.env
+++ b/.env
@@ -28,7 +28,7 @@ FEDORA=33
PYTHON=3.6
LLVM=11
CLANG_TOOLS=8
-RUST=nightly-2020-11-19
+RUST=nightly-2020-11-24
GO=1.12
NODE=14
MAVEN=3.5.4
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index bcdb561..adbdae6 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -50,7 +50,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- rust: [nightly-2020-11-19]
+ rust: [nightly-2020-11-24]
env:
RUST: ${{ matrix.rust }}
steps:
@@ -96,7 +96,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- rust: [nightly-2020-11-19]
+ rust: [nightly-2020-11-24]
steps:
- name: Install Rust
uses: actions-rs/toolchain@v1
@@ -134,7 +134,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- rust: [nightly-2020-11-19]
+ rust: [nightly-2020-11-24]
steps:
- name: Install Rust
uses: actions-rs/toolchain@v1
diff --git a/.github/workflows/rust_cron.yml b/.github/workflows/rust_cron.yml
index c374865..fed6a99 100644
--- a/.github/workflows/rust_cron.yml
+++ b/.github/workflows/rust_cron.yml
@@ -35,7 +35,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- rust: [nightly-2020-11-19]
+ rust: [nightly-2020-11-24]
env:
RUST: ${{ matrix.rust }}
steps:
diff --git a/ci/docker/debian-10-rust.dockerfile b/ci/docker/debian-10-rust.dockerfile
index 2c74772..39df235 100644
--- a/ci/docker/debian-10-rust.dockerfile
+++ b/ci/docker/debian-10-rust.dockerfile
@@ -33,11 +33,12 @@ RUN wget -q -O - https://github.com/google/flatbuffers/archive/v${flatbuffers}.t
cd / && \
rm -rf flatbuffers-${flatbuffers}
-ARG rust=nightly-2020-11-19
+ARG rust=nightly-2020-11-24
# freeze the version for deterministic builds
RUN rustup default ${rust} && \
- rustup component add rustfmt --toolchain ${rust}-x86_64-unknown-linux-gnu
+ rustup component add rustfmt --toolchain ${rust}-x86_64-unknown-linux-gnu && \
+ rustup toolchain add stable-x86_64-unknown-linux-gnu
# Compile a dummy program, so that the dependencies are compiled and cached on a layer
# see https://stackoverflow.com/a/58474618/931303 for details
diff --git a/ci/scripts/rust_test.sh b/ci/scripts/rust_test.sh
index 254ea43..881cdfb 100755
--- a/ci/scripts/rust_test.sh
+++ b/ci/scripts/rust_test.sh
@@ -27,25 +27,29 @@ export PARQUET_TEST_DATA=${arrow_dir}/cpp/submodules/parquet-testing/data
pushd ${source_dir}
-# run unit tests
-cargo test
+# run unit tests excluding arrow, which is run separately
+cargo test --workspace --exclude arrow
+
+# test datafusion examples
+pushd datafusion
+cargo run --example csv_sql
+cargo run --example parquet_sql
+popd
+
+# ARROW-10757 clean artefacts to reclaim space
+cargo clean
+
# run unit tests with SIMD on
pushd arrow
cargo test --features "simd"
-popd
+# run unit tests with stable Rust
+cargo +stable test
# test arrow examples
-pushd arrow
cargo run --example builders
cargo run --example dynamic_types
cargo run --example read_csv
cargo run --example read_csv_infer_schema
popd
-# test datafusion examples
-pushd datafusion
-cargo run --example csv_sql
-cargo run --example parquet_sql
-popd
-
popd
diff --git a/rust/rust-toolchain b/rust/rust-toolchain
index 340dfaa..ed4dad9 100644
--- a/rust/rust-toolchain
+++ b/rust/rust-toolchain
@@ -1 +1 @@
-nightly-2020-11-19
+nightly-2020-11-24