commons-lang dependency?

[Dan Diephouse <da...@envoisolutions.com>]

I see that the common module has a declared dependency on commons-lang. Is
this an optional dependency? Which modules require it?

I'd be against a hard dependency on commons-lang because we've already got a
load of dependencies, but if its optional (i.e. only required for JBI or
WS-*), we can just mark it as <optional> in the pom.

Thanks,
- Dan


-- 
Dan Diephouse
Envoi Solutions
http://envoisolutions.com | http://netzooid.com/blog

RE: commons-lang dependency?

["Tully, Gary" <Ga...@iona.com>]

Hi,
The dependency could be optional as it is currently only used by the xjc
ts plugin that adds a toString() method to the generated jaxb types.  
  > wsdl2java -xjc-Xts  ..

A user could however call
org.apache.cxf.jaxb.JAXBToStringBuilder.valueOf() directly to
programmatically splash out the content of a JAXB type, which would be
expected to work. This would be a half way house to enabling toString
for all generated types.

My main motivation for adding the explicit dependency was to make this
feature work easily out of the box.

If the dependency is optional, what is the strategy for a user enabling
the feature? 
Does the user have to manually manage the classpath or can we provide a
lib directory from which all jars are automatically available?

Will an optional dependency appear in the classpath of the cxf-manifest
jar?

Thanks,
Gary.



> -----Original Message-----
> From: James Mao [mailto:james.mao@iona.com] 
> Sent: 15 July 2007 02:45
> To: cxf-dev@incubator.apache.org
> Subject: Re: commons-lang dependency?
> 
> After a quick search
> 
> ./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToString
> Style.java:import
> org.apache.commons.lang.builder.ToStringBuilder;
> ./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToString
> Builder.java:import
> org.apache.commons.lang.builder.ToStringStyle;
> 
> ./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToString
> Style.java:importorg.apache.commons.lang.SystemUtils;
> ./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToString
> Style.java:importorg.apache.commons.lang.builder.ToStringBuilder;
> ./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToString
> Style.java:importorg.apache.commons.lang.builder.ToStringStyle;
> ./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToString
> Style.java:     
> *@see org.apache.commons.lang.builder.ToStringStyle
> 
> ./common/common/src/test/java/org/apache/cxf/jaxb/JAXBElementT
> oStringStyleTest.java:import
> org.apache.commons.lang.builder.ToStringBuilder;
> 
> ./systests/src/test/java/org/apache/cxf/systest/jaxb/model/Ext
> endedWidget.java:import
> org.apache.commons.lang.builder.EqualsBuilder;
> ./systests/src/test/java/org/apache/cxf/systest/jaxb/model/Ext
> endedWidget.java:import
> org.apache.commons.lang.builder.ToStringBuilder;
> ./systests/src/test/java/org/apache/cxf/systest/jaxb/model/Wid
> get.java:import
> org.apache.commons.lang.builder.EqualsBuilder;
> ./systests/src/test/java/org/apache/cxf/systest/jaxb/model/Wid
> get.java:import
> org.apache.commons.lang.builder.ToStringBuilder;
> 
> 
> Looks like JAXBToStringStyle and JAXBToStringStyle heavily 
> used in the xjc plugin
> 
> I think commons-lang is ok, will that be a problem?
> 
> James
> 
> > I see that the common module has a declared dependency on 
> > commons-lang. Is this an optional dependency? Which modules require 
> > it?
> >
> > I'd be against a hard dependency on commons-lang because 
> we've already 
> > got a load of dependencies, but if its optional (i.e. only required 
> > for JBI or WS-*), we can just mark it as <optional> in the pom.
> >
> > Thanks,
> > - Dan
> >
> >
> 

----------------------------
IONA Technologies PLC (registered in Ireland)
Registered Number: 171387
Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland

Re: commons-lang dependency?

[James Mao <ja...@iona.com>]

After a quick search

./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToStringStyle.java:import 
org.apache.commons.lang.builder.ToStringBuilder;
./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToStringBuilder.java:import 
org.apache.commons.lang.builder.ToStringStyle;

./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToStringStyle.java:importorg.apache.commons.lang.SystemUtils;
./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToStringStyle.java:importorg.apache.commons.lang.builder.ToStringBuilder;
./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToStringStyle.java:importorg.apache.commons.lang.builder.ToStringStyle;
./common/common/src/main/java/org/apache/cxf/jaxb/JAXBToStringStyle.java:     
*@see org.apache.commons.lang.builder.ToStringStyle

./common/common/src/test/java/org/apache/cxf/jaxb/JAXBElementToStringStyleTest.java:import 
org.apache.commons.lang.builder.ToStringBuilder;

./systests/src/test/java/org/apache/cxf/systest/jaxb/model/ExtendedWidget.java:import 
org.apache.commons.lang.builder.EqualsBuilder;
./systests/src/test/java/org/apache/cxf/systest/jaxb/model/ExtendedWidget.java:import 
org.apache.commons.lang.builder.ToStringBuilder;
./systests/src/test/java/org/apache/cxf/systest/jaxb/model/Widget.java:import 
org.apache.commons.lang.builder.EqualsBuilder;
./systests/src/test/java/org/apache/cxf/systest/jaxb/model/Widget.java:import 
org.apache.commons.lang.builder.ToStringBuilder;


Looks like JAXBToStringStyle and JAXBToStringStyle heavily used in the 
xjc plugin

I think commons-lang is ok, will that be a problem?

James

> I see that the common module has a declared dependency on 
> commons-lang. Is
> this an optional dependency? Which modules require it?
>
> I'd be against a hard dependency on commons-lang because we've already 
> got a
> load of dependencies, but if its optional (i.e. only required for JBI or
> WS-*), we can just mark it as <optional> in the pom.
>
> Thanks,
> - Dan
>
>