You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2012/02/28 23:46:13 UTC
svn commit: r1294878 -
/maven/sandbox/trunk/plugins/asf-svnpubsub-plugin/src/main/java/org/apache/maven/plugins/svnpubsub/SvnpubsubPublishMojo.java
Author: hboutemy
Date: Tue Feb 28 22:46:13 2012
New Revision: 1294878
URL: http://svn.apache.org/viewvc?rev=1294878&view=rev
Log:
questions about newline normalization
Modified:
maven/sandbox/trunk/plugins/asf-svnpubsub-plugin/src/main/java/org/apache/maven/plugins/svnpubsub/SvnpubsubPublishMojo.java
Modified: maven/sandbox/trunk/plugins/asf-svnpubsub-plugin/src/main/java/org/apache/maven/plugins/svnpubsub/SvnpubsubPublishMojo.java
URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/plugins/asf-svnpubsub-plugin/src/main/java/org/apache/maven/plugins/svnpubsub/SvnpubsubPublishMojo.java?rev=1294878&r1=1294877&r2=1294878&view=diff
==============================================================================
--- maven/sandbox/trunk/plugins/asf-svnpubsub-plugin/src/main/java/org/apache/maven/plugins/svnpubsub/SvnpubsubPublishMojo.java (original)
+++ maven/sandbox/trunk/plugins/asf-svnpubsub-plugin/src/main/java/org/apache/maven/plugins/svnpubsub/SvnpubsubPublishMojo.java Tue Feb 28 22:46:13 2012
@@ -83,6 +83,7 @@ public class SvnpubsubPublishMojo
private void normalizeNewlines( File f )
throws IOException
{
+ // FIXME: only text files should be normalized, not binary
File tmpFile = null;
InputStreamReader isr = null;
OutputStreamWriter osw = null;
@@ -97,7 +98,7 @@ public class SvnpubsubPublishMojo
while ( ( nRead = isr.read( buffer ) ) > 0 )
{
String content = new String( buffer, 0, nRead );
- content = content.replaceAll( "\r", "" );
+ content = content.replaceAll( "\r", "" ); // FIXME: normalize to Unix EOL? not to system EOL?
osw.write( content );
}
}