You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/09/06 08:32:29 UTC

[GitHub] [calcite] hsyuan commented on a change in pull request #1442: [CALCITE-3319] Remove throwing AssertionError code in ReduceDecimalsRule

hsyuan commented on a change in pull request #1442: [CALCITE-3319] Remove throwing AssertionError code in ReduceDecimalsRule
URL: https://github.com/apache/calcite/pull/1442#discussion_r321630504
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/ReduceDecimalsRule.java
 ##########
 @@ -152,13 +152,6 @@ public RexNode visitCall(RexCall call) {
       }
 
       // permanently updates a call in place
 
 Review comment:
   Should the comment be removed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services