You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "James E. King, III (JIRA)" <ji...@apache.org> on 2016/11/17 21:47:58 UTC
[jira] [Resolved] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS
(and other variables passed to include_directories()) is empty
[ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James E. King, III resolved THRIFT-3828.
----------------------------------------
Resolution: Won't Fix
Fix Version/s: 0.11.0
Based on the discussion I am going to resolve this as "Won't Fix". It sounds like the issue is external to the project and can be configured away with cmake build time variables, plus a future update to CMake may resolve it. If you disagree feel free to re-open it and explain further the reasons for removing the SYSTEM include paths.
> cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3828
> URL: https://issues.apache.org/jira/browse/THRIFT-3828
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Reporter: Cody Schafer
> Assignee: James E. King, III
> Priority: Minor
> Fix For: 0.11.0
>
> Attachments: 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch
>
>
> This is due to the current quoting of those variables when passed to `include_directories()`. These variables may (and soon will, see below) be empty in the case where the include directory is a system include path that is implicitly included.
> I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't work with includes that are part of the platform/system include path (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types of directories to Boost_INCLUDE_DIRS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)