You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GuoLei Yi <yi...@gmail.com> on 2022/12/06 04:22:52 UTC
Remove non-vectorization code
Hi All Developers,
Vectorization is introduced into Doris in 1.0 which is released
earlier this year. Many companies is using 1.1.x and it is very very
Fast and Stable. I think it's time to remove non-vectorization code
now. Following is my considerations:
- Lots of company is using doris 1.1.x and it is stable.
- 1.1-lts is a LTS branch, we will maintain it and fix bugs for it, If
you need non-vectorization code, I think 1.1 will solve your problem.
- 1.2 is now released, many features like array, JsonB, nest loop
join, decimalv3, datev2 and etc. are not implemented on
non-vectorization engine. So if a user is using 1.2 and using some new
features then it could not rollback to non-vectorization engine any
more.
- We need to refactor some code but we need to maintain these
non-vectorization code, it is very hard and it is very likely to
import BUGs and there are not many developers could add feature or fix
bugs for non-vectorization code.
So that, I think it's time to remove non-vectorization code now to
move Fast and Stable!!!
--
Best Regards,
Yi Guo Lei
SelectDB
The Best Cloud Native Platform for Apache Doris
Tel:134-3991-0228
Email:yiguolei@gmail.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org
Re: 回复： Remove non-vectorization code
Posted by GuoLei Yi <yi...@gmail.com>.
Nobody has an objection here and 5 people agree.
So that, we will begin to remove non-vectorization code now.
Gabriel Lee <ga...@gmail.com> 于2022年12月7日周三 19:08写道：
>
> +1. Make sense for both users and developers
>
> Best,
> Gabriel
>
> On Tue, 6 Dec 2022 at 17:08, Mingyu Chen <mo...@163.com> wrote:
>
> > Agreed.
> > The non-vec code can be maintained on branch-1.1-lts, and branch-1.2-lts.
> >
> >
> >
> >
> > --
> >
> > 此致！Best Regards
> > 陈明雨 Mingyu Chen
> >
> > Email:
> > morningman@apache.org
> >
> >
> >
> >
> >
> > 在 2022-12-06 16:24:00，"BiteTheDDDDt" <px...@qq.com.INVALID> 写道：
> > >+1, it will be helpful
> > >
> > >
> > >
> > >
> > >BiteTheDDDDt
> > >pxl290@qq.com
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >------------------ 原始邮件 ------------------
> > >发件人:
> > "dev"
> > <
> > tengjp@outlook.com>;
> > >发送时间: 2022年12月6日(星期二) 下午4:22
> > >收件人: "dev@doris.apache.org"<dev@doris.apache.org>;
> > >
> > >主题: Re: Remove non-vectorization code
> > >
> > >
> > >
> > >+1
> > >
> > >在 2022/12/6 13:38，“vin jake”<jakevingoo@gmail.com> 写入:
> > >
> > > +1
> > > It's enough to keep non-vectorization code just in
> > 1.1-lts
> > > It's time to remove non-vectorization code now in
> > master
> > >
> > > On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi <
> > yiguolei@gmail.com> wrote:
> > >
> > > > Hi All Developers,
> > > >
> > > > Vectorization is introduced into Doris in 1.0
> > which is released
> > > > earlier this year. Many companies is using 1.1.x
> > and it is very very
> > > > Fast and Stable. I think it's time to
> > remove non-vectorization code
> > > > now. Following is my considerations:
> > > >
> > > > - Lots of company is using doris 1.1.x and it is
> > stable.
> > > > - 1.1-lts is a LTS branch, we will maintain it
> > and fix bugs for it, If
> > > > you need non-vectorization code, I think 1.1 will
> > solve your problem.
> > > > - 1.2 is now released, many features like array,
> > JsonB, nest loop
> > > > join, decimalv3, datev2 and etc. are not
> > implemented on
> > > > non-vectorization engine. So if a user is using
> > 1.2 and using some new
> > > > features then it could not rollback to
> > non-vectorization engine any
> > > > more.
> > > > - We need to refactor some code but we need to
> > maintain these
> > > > non-vectorization code, it is very hard and it is
> > very likely to
> > > > import BUGs and there are not many developers
> > could add feature or fix
> > > > bugs for non-vectorization code.
> > > >
> > > > So that, I think it's time to remove
> > non-vectorization code now to
> > > > move Fast and Stable!!!
> > > >
> > > > --
> > > > Best Regards,
> > > > Yi Guo Lei
> > > > SelectDB
> > > > The Best Cloud Native Platform for Apache Doris
> > > > Tel:134-3991-0228
> > > > Email:yiguolei@gmail.com
> > > >
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail:
> > dev-unsubscribe@doris.apache.org
> > > > For additional commands, e-mail:
> > dev-help@doris.apache.org
> > > >
> > > >
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> > >For additional commands, e-mail: dev-help@doris.apache.org
> >
--
Best Regards,
Yi Guo Lei
SelectDB
The Best Cloud Native Platform for Apache Doris
Tel:134-3991-0228
Email:yiguolei@gmail.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org
Re: 回复： Remove non-vectorization code
Posted by Gabriel Lee <ga...@gmail.com>.
+1. Make sense for both users and developers
Best,
Gabriel
On Tue, 6 Dec 2022 at 17:08, Mingyu Chen <mo...@163.com> wrote:
> Agreed.
> The non-vec code can be maintained on branch-1.1-lts, and branch-1.2-lts.
>
>
>
>
> --
>
> 此致！Best Regards
> 陈明雨 Mingyu Chen
>
> Email:
> morningman@apache.org
>
>
>
>
>
> 在 2022-12-06 16:24:00，"BiteTheDDDDt" <px...@qq.com.INVALID> 写道：
> >+1, it will be helpful
> >
> >
> >
> >
> >BiteTheDDDDt
> >pxl290@qq.com
> >
> >
> >
> >
> >
> >
> >
> >
> >------------------ 原始邮件 ------------------
> >发件人:
> "dev"
> <
> tengjp@outlook.com>;
> >发送时间: 2022年12月6日(星期二) 下午4:22
> >收件人: "dev@doris.apache.org"<dev@doris.apache.org>;
> >
> >主题: Re: Remove non-vectorization code
> >
> >
> >
> >+1
> >
> >在 2022/12/6 13:38，“vin jake”<jakevingoo@gmail.com> 写入:
> >
> > +1
> > It's enough to keep non-vectorization code just in
> 1.1-lts
> > It's time to remove non-vectorization code now in
> master
> >
> > On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi <
> yiguolei@gmail.com> wrote:
> >
> > > Hi All Developers,
> > >
> > > Vectorization is introduced into Doris in 1.0
> which is released
> > > earlier this year. Many companies is using 1.1.x
> and it is very very
> > > Fast and Stable. I think it's time to
> remove non-vectorization code
> > > now. Following is my considerations:
> > >
> > > - Lots of company is using doris 1.1.x and it is
> stable.
> > > - 1.1-lts is a LTS branch, we will maintain it
> and fix bugs for it, If
> > > you need non-vectorization code, I think 1.1 will
> solve your problem.
> > > - 1.2 is now released, many features like array,
> JsonB, nest loop
> > > join, decimalv3, datev2 and etc. are not
> implemented on
> > > non-vectorization engine. So if a user is using
> 1.2 and using some new
> > > features then it could not rollback to
> non-vectorization engine any
> > > more.
> > > - We need to refactor some code but we need to
> maintain these
> > > non-vectorization code, it is very hard and it is
> very likely to
> > > import BUGs and there are not many developers
> could add feature or fix
> > > bugs for non-vectorization code.
> > >
> > > So that, I think it's time to remove
> non-vectorization code now to
> > > move Fast and Stable!!!
> > >
> > > --
> > > Best Regards,
> > > Yi Guo Lei
> > > SelectDB
> > > The Best Cloud Native Platform for Apache Doris
> > > Tel:134-3991-0228
> > > Email:yiguolei@gmail.com
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> dev-unsubscribe@doris.apache.org
> > > For additional commands, e-mail:
> dev-help@doris.apache.org
> > >
> > >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> >For additional commands, e-mail: dev-help@doris.apache.org
>
Re:回复： Remove non-vectorization code
Posted by Mingyu Chen <mo...@163.com>.
Agreed.
The non-vec code can be maintained on branch-1.1-lts, and branch-1.2-lts.
--
此致！Best Regards
陈明雨 Mingyu Chen
Email:
morningman@apache.org
在 2022-12-06 16:24:00，"BiteTheDDDDt" <px...@qq.com.INVALID> 写道：
>+1, it will be helpful
>
>
>
>
>BiteTheDDDDt
>pxl290@qq.com
>
>
>
>
>
>
>
>
>------------------ 原始邮件 ------------------
>发件人: "dev" <tengjp@outlook.com>;
>发送时间: 2022年12月6日(星期二) 下午4:22
>收件人: "dev@doris.apache.org"<dev@doris.apache.org>;
>
>主题: Re: Remove non-vectorization code
>
>
>
>+1
>
>在 2022/12/6 13:38，“vin jake”<jakevingoo@gmail.com> 写入:
>
> +1
> It's enough to keep non-vectorization code just in 1.1-lts
> It's time to remove non-vectorization code now in master
>
> On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi <yiguolei@gmail.com> wrote:
>
> > Hi All Developers,
> >
> > Vectorization is introduced into Doris in 1.0 which is released
> > earlier this year. Many companies is using 1.1.x and it is very very
> > Fast and Stable. I think it's time to remove non-vectorization code
> > now. Following is my considerations:
> >
> > - Lots of company is using doris 1.1.x and it is stable.
> > - 1.1-lts is a LTS branch, we will maintain it and fix bugs for it, If
> > you need non-vectorization code, I think 1.1 will solve your problem.
> > - 1.2 is now released, many features like array, JsonB, nest loop
> > join, decimalv3, datev2 and etc. are not implemented on
> > non-vectorization engine. So if a user is using 1.2 and using some new
> > features then it could not rollback to non-vectorization engine any
> > more.
> > - We need to refactor some code but we need to maintain these
> > non-vectorization code, it is very hard and it is very likely to
> > import BUGs and there are not many developers could add feature or fix
> > bugs for non-vectorization code.
> >
> > So that, I think it's time to remove non-vectorization code now to
> > move Fast and Stable!!!
> >
> > --
> > Best Regards,
> > Yi Guo Lei
> > SelectDB
> > The Best Cloud Native Platform for Apache Doris
> > Tel:134-3991-0228
> > Email:yiguolei@gmail.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> > For additional commands, e-mail: dev-help@doris.apache.org
> >
> >
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
>For additional commands, e-mail: dev-help@doris.apache.org
回复： Remove non-vectorization code
Posted by BiteTheDDDDt <px...@qq.com.INVALID>.
+1, it will be helpful
BiteTheDDDDt
pxl290@qq.com
------------------ 原始邮件 ------------------
发件人: "dev" <tengjp@outlook.com>;
发送时间: 2022年12月6日(星期二) 下午4:22
收件人: "dev@doris.apache.org"<dev@doris.apache.org>;
主题: Re: Remove non-vectorization code
+1
在 2022/12/6 13:38，“vin jake”<jakevingoo@gmail.com> 写入:
+1
It's enough to keep non-vectorization code just in 1.1-lts
It's time to remove non-vectorization code now in master
On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi <yiguolei@gmail.com> wrote:
> Hi All Developers,
>
> Vectorization is introduced into Doris in 1.0 which is released
> earlier this year. Many companies is using 1.1.x and it is very very
> Fast and Stable. I think it's time to remove non-vectorization code
> now. Following is my considerations:
>
> - Lots of company is using doris 1.1.x and it is stable.
> - 1.1-lts is a LTS branch, we will maintain it and fix bugs for it, If
> you need non-vectorization code, I think 1.1 will solve your problem.
> - 1.2 is now released, many features like array, JsonB, nest loop
> join, decimalv3, datev2 and etc. are not implemented on
> non-vectorization engine. So if a user is using 1.2 and using some new
> features then it could not rollback to non-vectorization engine any
> more.
> - We need to refactor some code but we need to maintain these
> non-vectorization code, it is very hard and it is very likely to
> import BUGs and there are not many developers could add feature or fix
> bugs for non-vectorization code.
>
> So that, I think it's time to remove non-vectorization code now to
> move Fast and Stable!!!
>
> --
> Best Regards,
> Yi Guo Lei
> SelectDB
> The Best Cloud Native Platform for Apache Doris
> Tel:134-3991-0228
> Email:yiguolei@gmail.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> For additional commands, e-mail: dev-help@doris.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org
Re: Remove non-vectorization code
Posted by T jp <te...@outlook.com>.
+1
在 2022/12/6 13:38，“vin jake”<ja...@gmail.com> 写入:
+1
It's enough to keep non-vectorization code just in 1.1-lts
It's time to remove non-vectorization code now in master
On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi <yi...@gmail.com> wrote:
> Hi All Developers,
>
> Vectorization is introduced into Doris in 1.0 which is released
> earlier this year. Many companies is using 1.1.x and it is very very
> Fast and Stable. I think it's time to remove non-vectorization code
> now. Following is my considerations:
>
> - Lots of company is using doris 1.1.x and it is stable.
> - 1.1-lts is a LTS branch, we will maintain it and fix bugs for it, If
> you need non-vectorization code, I think 1.1 will solve your problem.
> - 1.2 is now released, many features like array, JsonB, nest loop
> join, decimalv3, datev2 and etc. are not implemented on
> non-vectorization engine. So if a user is using 1.2 and using some new
> features then it could not rollback to non-vectorization engine any
> more.
> - We need to refactor some code but we need to maintain these
> non-vectorization code, it is very hard and it is very likely to
> import BUGs and there are not many developers could add feature or fix
> bugs for non-vectorization code.
>
> So that, I think it's time to remove non-vectorization code now to
> move Fast and Stable!!!
>
> --
> Best Regards,
> Yi Guo Lei
> SelectDB
> The Best Cloud Native Platform for Apache Doris
> Tel:134-3991-0228
> Email:yiguolei@gmail.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> For additional commands, e-mail: dev-help@doris.apache.org
>
>
Re: Remove non-vectorization code
Posted by vin jake <ja...@gmail.com>.
+1
It's enough to keep non-vectorization code just in 1.1-lts
It's time to remove non-vectorization code now in master
On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi <yi...@gmail.com> wrote:
> Hi All Developers,
>
> Vectorization is introduced into Doris in 1.0 which is released
> earlier this year. Many companies is using 1.1.x and it is very very
> Fast and Stable. I think it's time to remove non-vectorization code
> now. Following is my considerations:
>
> - Lots of company is using doris 1.1.x and it is stable.
> - 1.1-lts is a LTS branch, we will maintain it and fix bugs for it, If
> you need non-vectorization code, I think 1.1 will solve your problem.
> - 1.2 is now released, many features like array, JsonB, nest loop
> join, decimalv3, datev2 and etc. are not implemented on
> non-vectorization engine. So if a user is using 1.2 and using some new
> features then it could not rollback to non-vectorization engine any
> more.
> - We need to refactor some code but we need to maintain these
> non-vectorization code, it is very hard and it is very likely to
> import BUGs and there are not many developers could add feature or fix
> bugs for non-vectorization code.
>
> So that, I think it's time to remove non-vectorization code now to
> move Fast and Stable!!!
>
> --
> Best Regards,
> Yi Guo Lei
> SelectDB
> The Best Cloud Native Platform for Apache Doris
> Tel:134-3991-0228
> Email:yiguolei@gmail.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> For additional commands, e-mail: dev-help@doris.apache.org
>
>