You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/15 11:07:49 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6274: Fix typo error: XXX_DYNTIMEO_YYY to XXX_DYNTIMEOUT_YYY

xiaoxiang781216 opened a new pull request, #6274:
URL: https://github.com/apache/incubator-nuttx/pull/6274

   ## Summary
   Found in #6226 
   
   ## Impact
   None
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6274: Fix typo error: XXX_DYNTIMEO_YYY to XXX_DYNTIMEOUT_YYY

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6274:
URL: https://github.com/apache/incubator-nuttx/pull/6274#discussion_r873163197


##########
arch/arm/src/efm32/efm32_i2c.c:
##########
@@ -513,7 +513,7 @@ static useconds_t efm32_i2c_tousecs(int msgc, struct i2c_msg_s *msgs)
    * factor.
    */
 
-  return (useconds_t) (CONFIG_EFM32_I2C_DYNTIMEO_USECPERBYTE * bytecount);
+  return (useconds_t) (CONFIG_EFM32_I2C_DYNTIMEOUT_USECPERBYTE * bytecount);

Review Comment:
   Oah... I didn't expect so radical changes.
   I think thinking only about changing
   ```
   #ifdef CONFIG_EFM32_I2C_DYNTIMEOUT
   static useconds_t efm32_i2c_tousecs(int msgc, struct i2c_msg_s *msgs);
   #endif /* CONFIG_EFM32_I2C_DYNTIMEOUT */
   ```
   to 
   ```
   #ifdef CONFIG_EFM32_I2C_DYNTIMEO
   static useconds_t efm32_i2c_tousecs(int msgc, struct i2c_msg_s *msgs);
   #endif /* CONFIG_EFM32_I2C_DYNTIMEO */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6274: Fix typo error: XXX_DYNTIMEO_YYY to XXX_DYNTIMEOUT_YYY

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6274:
URL: https://github.com/apache/incubator-nuttx/pull/6274#discussion_r873163453


##########
arch/arm/src/efm32/efm32_i2c.c:
##########
@@ -513,7 +513,7 @@ static useconds_t efm32_i2c_tousecs(int msgc, struct i2c_msg_s *msgs)
    * factor.
    */
 
-  return (useconds_t) (CONFIG_EFM32_I2C_DYNTIMEO_USECPERBYTE * bytecount);
+  return (useconds_t) (CONFIG_EFM32_I2C_DYNTIMEOUT_USECPERBYTE * bytecount);

Review Comment:
   I mean I'm fine with `I2C_DYNTIMEO` (and not changing to `I2C_DYNTIMEOUT`), just would like to have same macro used in all places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6274: arm/efm32: Fix typo error: CONFIG_EFM32_I2C_DYNTIMEOUT to CONFIG_EFM32_I2C_DYNTIMEO

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6274:
URL: https://github.com/apache/incubator-nuttx/pull/6274#discussion_r873171895


##########
arch/arm/src/efm32/efm32_i2c.c:
##########
@@ -513,7 +513,7 @@ static useconds_t efm32_i2c_tousecs(int msgc, struct i2c_msg_s *msgs)
    * factor.
    */
 
-  return (useconds_t) (CONFIG_EFM32_I2C_DYNTIMEO_USECPERBYTE * bytecount);
+  return (useconds_t) (CONFIG_EFM32_I2C_DYNTIMEOUT_USECPERBYTE * bytecount);

Review Comment:
   Ok, change CONFIG_EFM32_I2C_DYNTIMEOUT to CONFIG_EFM32_I2C_DYNTIMEO instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6274: arm/efm32: Fix typo error: CONFIG_EFM32_I2C_DYNTIMEOUT to CONFIG_EFM32_I2C_DYNTIMEO

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6274:
URL: https://github.com/apache/incubator-nuttx/pull/6274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org