You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/08/31 19:31:33 UTC

[Impala-ASF-CR](branch-4.5.2) IMPALA-15217: Fix avro.schema.url tests on S3, Ozone

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24772


Change subject: IMPALA-15217: Fix avro.schema.url tests on S3, Ozone
......................................................................

IMPALA-15217: Fix avro.schema.url tests on S3, Ozone

With S3 and Ozone, we get different error messages when the file doesn't
exist. Assert the general error prefix we add.

For Ozone we need to account for different warehouse paths.

Change-Id: I5712ed42877bf289f07a4a5a46ca8c3061d7eabc
---
M bin/load-data.py
M testdata/bin/create-load-data.sh
R testdata/data/schemas/bad_avro_schemas/bad_json.json
R testdata/data/schemas/bad_avro_schemas/neg_precision.json
R testdata/data/schemas/bad_avro_schemas/neg_scale.json
R testdata/data/schemas/bad_avro_schemas/no_name.json
R testdata/data/schemas/bad_avro_schemas/no_precision.json
R testdata/data/schemas/bad_avro_schemas/no_type.json
R testdata/data/schemas/bad_avro_schemas/union.json
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-checks.test
M tests/query_test/test_avro_schema_urls.py
11 files changed, 12 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/24772/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.5.2
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5712ed42877bf289f07a4a5a46ca8c3061d7eabc
Gerrit-Change-Number: 24772
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR](branch-4.5.2) IMPALA-15217: Fix avro.schema.url tests on S3, Ozone

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24772 )

Change subject: IMPALA-15217: Fix avro.schema.url tests on S3, Ozone
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.5.2
Gerrit-MessageType: comment
Gerrit-Change-Id: I5712ed42877bf289f07a4a5a46ca8c3061d7eabc
Gerrit-Change-Number: 24772
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Sep 2026 03:20:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.5.2) IMPALA-15217: Fix avro.schema.url tests on S3, Ozone

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24772 )

Change subject: IMPALA-15217: Fix avro.schema.url tests on S3, Ozone
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.5.2
Gerrit-MessageType: comment
Gerrit-Change-Id: I5712ed42877bf289f07a4a5a46ca8c3061d7eabc
Gerrit-Change-Number: 24772
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Aug 2026 22:40:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.5.2) IMPALA-15217: Fix avro.schema.url tests on S3, Ozone

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24772 )

Change subject: IMPALA-15217: Fix avro.schema.url tests on S3, Ozone
......................................................................

IMPALA-15217: Fix avro.schema.url tests on S3, Ozone

With S3 and Ozone, we get different error messages when the file doesn't
exist. Assert the general error prefix we add.

For Ozone we need to account for different warehouse paths.

Change-Id: I5712ed42877bf289f07a4a5a46ca8c3061d7eabc
Reviewed-on: http://gerrit.cloudera.org:8080/24772
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M bin/load-data.py
M testdata/bin/create-load-data.sh
R testdata/data/schemas/bad_avro_schemas/bad_json.json
R testdata/data/schemas/bad_avro_schemas/neg_precision.json
R testdata/data/schemas/bad_avro_schemas/neg_scale.json
R testdata/data/schemas/bad_avro_schemas/no_name.json
R testdata/data/schemas/bad_avro_schemas/no_precision.json
R testdata/data/schemas/bad_avro_schemas/no_type.json
R testdata/data/schemas/bad_avro_schemas/union.json
M testdata/workloads/functional-query/queries/QueryTest/avro-schema-checks.test
M tests/query_test/test_avro_schema_urls.py
11 files changed, 12 insertions(+), 13 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Michael Smith: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.5.2
Gerrit-MessageType: merged
Gerrit-Change-Id: I5712ed42877bf289f07a4a5a46ca8c3061d7eabc
Gerrit-Change-Number: 24772
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>