You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/10/25 09:23:53 UTC

[GitHub] [calcite] asolimando commented on pull request #2948: [CALCITE-5340] Tests should fail when actual and expected XML reference files are not identical

asolimando commented on PR #2948:
URL: https://github.com/apache/calcite/pull/2948#issuecomment-1290252155

   > @asolimando The PR looks great. The only question I got is why `TopDownOptTest` and `RuleMatchVisualizerTest` are not touched in this PR?
   
   @libenchao, thanks a lot for catching it! I totally missed `TopDownOptTest`, for `RuleMatchVisualizerTest` I tried to implement the check in its parent class (`RelOptTestBase`) but it proved difficult, I gave up and forgot about that class.
   
   I have covered them both in a new commit, please have another look if you have any spare cycles.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org