You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/26 08:53:24 UTC

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4740: [New Transformation function] Presto compatible DateTrunc

siddharthteotia commented on issue #4740: [New Transformation function] Presto compatible DateTrunc
URL: https://github.com/apache/incubator-pinot/pull/4740#issuecomment-546584338
 
 
   > Hi @siddharthteotia ... take a look at the PR now. I added the requested e2e unit test and also added documentation. So this UDF is now "unhidden" and can be used by anyone.
   > 
   > I believe this should allay your concerns and allow this PR to be merged in. Let me know if you think something else needs to be done here.
   > 
   > Thanks for the review !
   
   Thanks, @agrawaldevesh. LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org