You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/07/29 06:58:19 UTC

[GitHub] [servicecomb-java-chassis] zhaozw opened a new pull request, #3239: [#SCB-2648] ClientPoolManager#findByContext will cause memory leak

zhaozw opened a new pull request, #3239:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3239

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3239: [#SCB-2648] ClientPoolManager#findByContext will cause memory leak

Posted by GitBox <gi...@apache.org>.
liubao68 commented on PR #3239:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3239#issuecomment-1207222318

   This seams not a fix, just try to add some avoidance.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #3239: [#SCB-2648] ClientPoolManager#findByContext will cause memory leak

Posted by GitBox <gi...@apache.org>.
liubao68 commented on PR #3239:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3239#issuecomment-1207433989

   see https://github.com/apache/servicecomb-java-chassis/pull/3268


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3239: [#SCB-2648] ClientPoolManager#findByContext will cause memory leak

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3239:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3239#issuecomment-1198965304

   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3239](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc33a3f) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/0553dac62db96ecbff26e6958bc42820234eeca1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0553dac) will **increase** coverage by `0.05%`.
   > The diff coverage is `75.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3239      +/-   ##
   ============================================
   + Coverage     77.44%   77.49%   +0.05%     
     Complexity     1439     1439              
   ============================================
     Files          1629     1629              
     Lines         43413    43412       -1     
     Branches       3653     3653              
   ============================================
   + Hits          33623    33644      +21     
   + Misses         8279     8260      -19     
   + Partials       1511     1508       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...omb/foundation/vertx/client/ClientPoolManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC9jbGllbnQvQ2xpZW50UG9vbE1hbmFnZXIuamF2YQ==) | `90.00% <75.00%> (-1.90%)` | :arrow_down: |
   | [...icecomb/huaweicloud/servicestage/CasEnvConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVhd2VpLWNsb3VkL3NlcnZpY2VzdGFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvaHVhd2VpY2xvdWQvc2VydmljZXN0YWdlL0Nhc0VudkNvbmZpZy5qYXZh) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | :arrow_down: |
   | [.../apache/servicecomb/loadbalance/Configuration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvQ29uZmlndXJhdGlvbi5qYXZh) | `61.53% <0.00%> (-3.08%)` | :arrow_down: |
   | [...ecomb/provider/pojo/PojoConsumerMetaRefresher.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vUG9qb0NvbnN1bWVyTWV0YVJlZnJlc2hlci5qYXZh) | `75.60% <0.00%> (-2.44%)` | :arrow_down: |
   | [...icecomb/bizkeeper/HystrixCommandPropertiesExt.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1iaXprZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2JpemtlZXBlci9IeXN0cml4Q29tbWFuZFByb3BlcnRpZXNFeHQuamF2YQ==) | `92.25% <0.00%> (-1.41%)` | :arrow_down: |
   | [...comb/loadbalance/ServiceCombLoadBalancerStats.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvU2VydmljZUNvbWJMb2FkQmFsYW5jZXJTdGF0cy5qYXZh) | `82.43% <0.00%> (-1.36%)` | :arrow_down: |
   | [...b/router/distribute/AbstractRouterDistributor.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcm91dGVyL2Rpc3RyaWJ1dGUvQWJzdHJhY3RSb3V0ZXJEaXN0cmlidXRvci5qYXZh) | `80.88% <0.00%> (-0.94%)` | :arrow_down: |
   | [...mb/core/handler/impl/ProducerOperationHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9oYW5kbGVyL2ltcGwvUHJvZHVjZXJPcGVyYXRpb25IYW5kbGVyLmphdmE=) | `50.63% <0.00%> (-0.65%)` | :arrow_down: |
   | [...n/java/org/apache/servicecomb/injection/Fault.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvaW5qZWN0aW9uL0ZhdWx0LmphdmE=) | `100.00% <0.00%> (ø)` | |
   | ... and [27 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3239/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 closed pull request #3239: [#SCB-2648] ClientPoolManager#findByContext will cause memory leak

Posted by GitBox <gi...@apache.org>.
liubao68 closed pull request #3239: [#SCB-2648] ClientPoolManager#findByContext will cause memory leak
URL: https://github.com/apache/servicecomb-java-chassis/pull/3239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org