You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/18 03:57:41 UTC
[GitHub] [flink] 1996fanrui opened a new pull request #18384: [FLINK-22643][network] Reuse tpc connections between taskmanagers
1996fanrui opened a new pull request #18384:
URL: https://github.com/apache/flink/pull/18384
## What is the purpose of the change
Reuse tpc connections between taskmanagers
## Brief change log
Reuse tpc connections between taskmanagers.
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
Added test that PartitionRequestClientFactoryTest#testReuseNettyPartitionRequestClient.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18384: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18384:
URL: https://github.com/apache/flink/pull/18384#issuecomment-1015051197
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3cbd0a1b5e27a8699edb9f7bb33e44f4aa1ab72d (Tue Jan 18 04:02:03 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18384: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18384:
URL: https://github.com/apache/flink/pull/18384#issuecomment-1015050232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3cbd0a1b5e27a8699edb9f7bb33e44f4aa1ab72d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29606",
"triggerID" : "3cbd0a1b5e27a8699edb9f7bb33e44f4aa1ab72d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3cbd0a1b5e27a8699edb9f7bb33e44f4aa1ab72d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29606)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18384: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18384:
URL: https://github.com/apache/flink/pull/18384#issuecomment-1015050232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3cbd0a1b5e27a8699edb9f7bb33e44f4aa1ab72d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3cbd0a1b5e27a8699edb9f7bb33e44f4aa1ab72d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3cbd0a1b5e27a8699edb9f7bb33e44f4aa1ab72d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #18384: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #18384:
URL: https://github.com/apache/flink/pull/18384#issuecomment-1015172952
Hey @1996fanrui , unfortunately as this is a change introducing new feature, we shouldn't port it to the previous branches. I'm closing this PR. This feature will have to wait for 1.15.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #18384: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on pull request #18384:
URL: https://github.com/apache/flink/pull/18384#issuecomment-1015281123
Thanks for your clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski closed pull request #18384: [FLINK-22643][network] Reuse tpc connections between taskmanagers
Posted by GitBox <gi...@apache.org>.
pnowojski closed pull request #18384:
URL: https://github.com/apache/flink/pull/18384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org