You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/22 06:15:46 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #12127: presto sample doc missing the set field method
Shoothzj opened a new pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127
### Motivation
presto doc missing the setField method
### Modifications
Add the missing set field method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127#issuecomment-925423154
Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update [all affected versions](https://github.com/apache/pulsar/tree/master/site2/website/versioned_docs)? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127#issuecomment-927200610
@sijie @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127#issuecomment-924619165
@Anonymitaet @sijie @codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on a change in pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127#discussion_r716122451
##########
File path: site2/docs/sql-getting-started.md
##########
@@ -117,18 +117,45 @@ You can query the mock data.
If you want to query your own data, you need to ingest your own data first. You can write a simple producer and write custom defined data to Pulsar. The following is an example.
```java
-public class Test {
-
- public static class Foo {
+public class TestProducer {
+
+ public static class Foo {
Review comment:
That's a demo program for others to copy. They may not use `lombok`, so i think use `set get` more friendly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127#issuecomment-925438896
> Thanks for your contribution. Does this affect only master or other versioned docs?
> If latter, could you please help update [all affected versions](https://github.com/apache/pulsar/tree/master/site2/website/versioned_docs)? Thanks
I have updated all versions, PTAL @Anonymitaet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on a change in pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127#discussion_r716120092
##########
File path: site2/docs/sql-getting-started.md
##########
@@ -117,18 +117,45 @@ You can query the mock data.
If you want to query your own data, you need to ingest your own data first. You can write a simple producer and write custom defined data to Pulsar. The following is an example.
```java
-public class Test {
-
- public static class Foo {
+public class TestProducer {
+
+ public static class Foo {
Review comment:
Use `@Data` and `@NoArgsConstructor` instead of implement get and set methods maybe better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127#issuecomment-925474929
@merlimat @eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #12127: presto sample doc missing the set field method
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #12127:
URL: https://github.com/apache/pulsar/pull/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org