You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/12/12 00:51:56 UTC
Review Request 41282: Added the interface for the V1 Executor HTTP
Library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41282/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change introduces an interface for the V1 Executor HTTP Library. The interface is similar in semantics to the corresponding scheduler library.
Diffs
-----
include/mesos/v1/executor.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/41282/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 41282: Added the interface for the V1 Executor HTTP
Library.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41282/#review114118
-----------------------------------------------------------
Ship it!
- Vinod Kone
On Dec. 12, 2015, 2:13 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41282/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 2:13 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces an interface for the V1 Executor HTTP Library. The interface is similar in semantics to the corresponding scheduler library.
>
>
> Diffs
> -----
>
> include/mesos/v1/executor.hpp PRE-CREATION
> src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e
>
> Diff: https://reviews.apache.org/r/41282/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41282: Added the interface for the V1 Executor HTTP
Library.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41282/#review110370
-----------------------------------------------------------
include/mesos/v1/executor.hpp (lines 63 - 64)
<https://reviews.apache.org/r/41282/#comment170177>
This seems `NOTE:` -worthy. Also, it would be good to point developers to the validation code.
- Joseph Wu
On Dec. 11, 2015, 6:13 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41282/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 6:13 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces an interface for the V1 Executor HTTP Library. The interface is similar in semantics to the corresponding scheduler library.
>
>
> Diffs
> -----
>
> include/mesos/v1/executor.hpp PRE-CREATION
> src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e
>
> Diff: https://reviews.apache.org/r/41282/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 41282: Added the interface for the V1 Executor HTTP
Library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41282/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 2:13 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Add missing header to Makefile
Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550
Repository: mesos
Description
-------
This change introduces an interface for the V1 Executor HTTP Library. The interface is similar in semantics to the corresponding scheduler library.
Diffs (updated)
-----
include/mesos/v1/executor.hpp PRE-CREATION
src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e
Diff: https://reviews.apache.org/r/41282/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar