[GitHub] [camel-quarkus] jamesnetherton commented on issue #697: Fix #696 Test HTTPS with the HTTP clients

[GitBox <gi...@apache.org>]

jamesnetherton commented on issue #697: Fix #696 Test HTTPS with the HTTP clients
URL: https://github.com/apache/camel-quarkus/pull/697#issuecomment-585148144
 
 
   Shouldn't this stuff be cached and restored on each PR?
   
   Are the cache keys we use correct (I'm no expert here)? We have `maven-${{ github.sha }}`. Wont this cache the m2 repo for the commit SHA that triggered the GitHub action? I.e every commit on a PR forces the cache to be generated?
   
   Would it not be better for the key to be based the content of the BOMs? E.g something like:
   
   ```
   - uses: actions/cache@v1
     with:
       path: ~/.m2/repository
       key: ${{ runner.os }}-maven-${{ hashFiles('**/poms/**/*.xml') }}
       restore-keys: |
         ${{ runner.os }}-maven-
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services