You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dungba88 (via GitHub)" <gi...@apache.org> on 2024/04/03 12:23:57 UTC
[PR] Rename NodeHash to FSTSuffixNodeCache [lucene]
dungba88 opened a new pull request, #13259:
URL: https://github.com/apache/lucene/pull/13259
### Description
Rename NodeHash to FSTSuffixNodeCache as NodeHash is rather an obscured name which doesn't tell its exact functionality. I also added the class Javadoc to explain what it is for and how it works, so that it would be easier to follow-up its implementation details (which I often struggled when working on it the first time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename NodeHash to FSTSuffixNodeCache + Javadoc improvement [lucene]
Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov commented on PR #13259:
URL: https://github.com/apache/lucene/pull/13259#issuecomment-2452660151
Thanks, this does seem much more explicit and helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename NodeHash to FSTSuffixNodeCache + Javadoc improvement [lucene]
Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov merged PR #13259:
URL: https://github.com/apache/lucene/pull/13259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename NodeHash to FSTSuffixNodeCache [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13259:
URL: https://github.com/apache/lucene/pull/13259#issuecomment-2062763499
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename NodeHash to FSTSuffixNodeCache [lucene]
Posted by "dungba88 (via GitHub)" <gi...@apache.org>.
dungba88 commented on PR #13259:
URL: https://github.com/apache/lucene/pull/13259#issuecomment-2451381448
Hi Lucene community, would someone kindly take a look at this PR? This is only minor renaming and Javadoc improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org