[GitHub] [flink] zentol commented on pull request #21349: Support Maven 3.3+

[GitBox <gi...@apache.org>]

zentol commented on PR #21349:
URL: https://github.com/apache/flink/pull/21349#issuecomment-1321757332

   Some discourse on why the PR is the way it is:
   
   # Could this be limited to modules that actually need this?
   
   Yes. We could determine which modules are relied upon by other modules and only enforce the optional flags for said module. This would however result in inconsistent module poms and additional work for the poor soul that added a dependency on another module.
   
   # Could this be achieved with exclusions?
   
   Yes-ish. We could add exclusions for all bundled dependencies in the consuming modules, and optionally add another module in between to centralize these exclusions in a single place. (Similar to what the -loader modules do, at the cost of even more modules).
   This however would require exclusions/bundling rules in 2 distinct files to be kept in sync. This is always problematic and can easily result in excess exclusions that _may_ cause problems down the line.
   It would additionally be more difficult to test this because there's no clear answer for a consuming module as to what should actually be excluded.
   We'd implicitly limit the setup to the one described in `Could this be limited to modules that actually need this?`.
   Making this work with IntelliJ would be quite noisy, as we'd have to setup the exclusions in a profile.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org