You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/10 06:11:03 UTC

[GitHub] [iotdb] wangchao316 commented on a change in pull request #2787: [IOTDB-1193] Remove redundant sync meta leader in CManager for cluster module

wangchao316 commented on a change in pull request #2787:
URL: https://github.com/apache/iotdb/pull/2787#discussion_r591089670



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -153,6 +153,14 @@ public static CMManager getInstance() {
     return CMManager.MManagerHolder.INSTANCE;
   }
 
+  public void syncMetaLeader() throws MetadataException {

Review comment:
       hi xinyu, this have a code smell.. need add coment..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org