You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/21 15:21:29 UTC
[GitHub] [cordova-ios] cclauss opened a new pull request #769: Add Python 3
compatibility to bin/cordova_plist_to_config_xml
cclauss opened a new pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769
These changes should be compatible with both Python 2 and Python 3.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] knight9999 edited a comment on issue #769: Add Python
3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
knight9999 edited a comment on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-590828824
I tried this PR with Python 3.6.4. But I got the following error.
```
TypeError: string argument expected, got 'bytes'
```
I feel it is better to use `BytesIO` with `ElementTree.write` in place of `StringIO` as follows.
(In my environment this can fix the above error)
```
diff --git a/bin/cordova_plist_to_config_xml b/bin/cordova_plist_to_config_xml
index f6c47505..94fe3371 100755
--- a/bin/cordova_plist_to_config_xml
+++ b/bin/cordova_plist_to_config_xml
@@ -38,6 +38,7 @@ try: # Python 2
except ImportError: # Python 3
from io import StringIO
+from io import BytesIO
def Usage():
sys.stderr.write(__doc__)
@@ -93,10 +94,11 @@ def ConvertPlist(src_path, dst_path):
root.append(ElementTree.Element('access', attrib={'origin':value}))
tree = ElementTree.ElementTree(root)
- s = StringIO()
+ # s = StringIO()
+ s = BytesIO()
tree.write(s, encoding='UTF-8')
mini_dom = minidom.parseString(s.getvalue())
- with open(dst_path, 'w') as out:
+ with open(dst_path, 'wb') as out:
out.write(mini_dom.toprettyxml(encoding='UTF-8'))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] cclauss commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
cclauss commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380301504
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -101,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print line,
+ print(line, end='')
Review comment:
Did you forget this line? `from __future__ import print_function`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] brodybits commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380874819
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -106,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print(line, end='')
+ print(line, end=' ')
Review comment:
I don't really understand (did not work with Python for about 10 years), hope someone else can review it. We do appreciate your efforts to get this whole Python compatibility issue fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on issue #769: Add Python 3
compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-587411944
Just as a side-note, this file seems to be used only for the Platform-Centered workflow.
There are multiple ways of going about creating a Platform-Centered project. One is a fresh project from Xcode. This means the Cordova's Xcode based project is not used and therefore does not have the `config.xml` file.
IMO, I think we do not have a lot of resources to focus on the Platform-Center workflow. I think it may have been discussed to consolidate our focus only on the CLI workflow and potentially dropping Platform-Center workflow.
If the changes work, we could just push it through and not spend too much time on this.
Just My Opinion...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] cclauss commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
cclauss commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380878801
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -106,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print(line, end='')
+ print(line, end=' ')
Review comment:
Which do we want?
```
>>> for char in "abcdefg":
... print(char, end="") # --> abcdefg
-- or --
>>> for char in "abcdefg":
... print(char, end="") # --> a b c d e f g
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] knight9999 edited a comment on issue #769: Add Python
3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
knight9999 edited a comment on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-590828824
I tried this PR with Python 3.6.4. But I got the following error.
```
TypeError: string argument expected, got 'bytes'
```
I feel it is better to use `BytesIO` with `ElementTree.write` in place of `StringIO` as follows.
(In my environment I can fix the above error)
```
diff --git a/bin/cordova_plist_to_config_xml b/bin/cordova_plist_to_config_xml
index f6c47505..94fe3371 100755
--- a/bin/cordova_plist_to_config_xml
+++ b/bin/cordova_plist_to_config_xml
@@ -38,6 +38,7 @@ try: # Python 2
except ImportError: # Python 3
from io import StringIO
+from io import BytesIO
def Usage():
sys.stderr.write(__doc__)
@@ -93,10 +94,11 @@ def ConvertPlist(src_path, dst_path):
root.append(ElementTree.Element('access', attrib={'origin':value}))
tree = ElementTree.ElementTree(root)
- s = StringIO()
+ # s = StringIO()
+ s = BytesIO()
tree.write(s, encoding='UTF-8')
mini_dom = minidom.parseString(s.getvalue())
- with open(dst_path, 'w') as out:
+ with open(dst_path, 'wb') as out:
out.write(mini_dom.toprettyxml(encoding='UTF-8'))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] DavidM42 commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
DavidM42 commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380303068
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -101,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print line,
+ print(line, end='')
Review comment:
Yeah, you're right. Never worked with that before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] NiklasMerz commented on issue #769: Add Python 3
compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-587087563
> lgtm. Asked if `end=''` really is needed but that's non breaking
If have no idea about python, that's why I got someone to review it who has :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] knight9999 commented on issue #769: Add Python 3
compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
knight9999 commented on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-590828824
I tried this PR with Python 3.6.4. But I got the following error.
```
TypeError: string argument expected, got 'bytes'
```
I feel it is better to use `BytesIO` with `ElementTree.write` in place of `StringIO` as follows.
```
diff --git a/bin/cordova_plist_to_config_xml b/bin/cordova_plist_to_config_xml
index f6c47505..94fe3371 100755
--- a/bin/cordova_plist_to_config_xml
+++ b/bin/cordova_plist_to_config_xml
@@ -38,6 +38,7 @@ try: # Python 2
except ImportError: # Python 3
from io import StringIO
+from io import BytesIO
def Usage():
sys.stderr.write(__doc__)
@@ -93,10 +94,11 @@ def ConvertPlist(src_path, dst_path):
root.append(ElementTree.Element('access', attrib={'origin':value}))
tree = ElementTree.ElementTree(root)
- s = StringIO()
+ # s = StringIO()
+ s = BytesIO()
tree.write(s, encoding='UTF-8')
mini_dom = minidom.parseString(s.getvalue())
- with open(dst_path, 'w') as out:
+ with open(dst_path, 'wb') as out:
out.write(mini_dom.toprettyxml(encoding='UTF-8'))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] cclauss commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
cclauss commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380878801
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -106,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print(line, end='')
+ print(line, end=' ')
Review comment:
Which do we want?
```
>>> for char in "abcdefg":
... print(char, end="") # --> abcdefg
-- or --
>>> for char in "abcdefg":
... print(char, end=" ") # --> a b c d e f g
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] DavidM42 commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
DavidM42 commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380293330
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -101,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print line,
+ print(line, end='')
Review comment:
Why is it important to overwrite the newline character at the end of print here? Does this need to print in one line? Else `end=''` could be left out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] brodybits commented on issue #769: Add Python 3
compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
brodybits commented on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-587568401
Agreed @erisu, let's get this merged.
I just raised #791 to avoid losing track of improving the [platform-centered workflow ([1])](https://cordova.apache.org/docs/en/latest/guide/platforms/ios/#platform-centered-workflow) and hopefully alleviate the need for Python (someday). Definitely very unfortunate that we cannot afford the resources to make this kind of improvement right now.
[1] https://cordova.apache.org/docs/en/latest/guide/platforms/ios/#platform-centered-workflow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] brodybits commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380865044
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -106,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print(line, end='')
+ print(line, end=' ')
Review comment:
Why add a space here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] brodybits commented on issue #769: Add Python 3
compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
brodybits commented on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-587639583
I think we want to drop this functionality in the near future, as I proposed in <https://github.com/apache/cordova/issues/198>. I wonder if we can get this fix into a minor release somehow. What do you think @erisu?
@erisu let's please get this merged in the next 12-24 hours if there are no objections, I do think it would be good to get this solution committed even if we do not want to support it too much longer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] brodybits edited a comment on issue #769: Add Python
3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
brodybits edited a comment on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-587568401
Agreed @erisu, let's get this merged.
~~I just raised #791 to avoid losing track of improving the [platform-centered workflow ([1])](https://cordova.apache.org/docs/en/latest/guide/platforms/ios/#platform-centered-workflow) and hopefully alleviate the need for Python (someday). Definitely very unfortunate that we cannot afford the resources to make this kind of improvement right now.~~
~~[1] https://cordova.apache.org/docs/en/latest/guide/platforms/ios/#platform-centered-workflow~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] brodybits commented on issue #769: Add Python 3
compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
brodybits commented on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-587038442
Thanks for the contribution, I just requested a review from some iOS experts. My apologies for the delay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] DavidM42 commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
DavidM42 commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380293330
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -101,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print line,
+ print(line, end='')
Review comment:
Why is it important to overwrite the newline character at the end of print here? Does this need to print in one line? Else `end=''` could be left out
Edit:
Just checked and `end=''` parameter produced a syntax error in my Python2.7.17 environment. Even if it works it may be safer to remove in terms of cross compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io commented on issue #769: Add Python 3
compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#issuecomment-576932626
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/769?src=pr&el=h1) Report
> Merging [#769](https://codecov.io/gh/apache/cordova-ios/pull/769?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/266d339ee80d381068f50065dfc132132ffd2e7f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/769?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #769 +/- ##
=======================================
Coverage 74.42% 74.42%
=======================================
Files 11 11
Lines 1830 1830
=======================================
Hits 1362 1362
Misses 468 468
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/769?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/769?src=pr&el=footer). Last update [266d339...da2511d](https://codecov.io/gh/apache/cordova-ios/pull/769?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] cclauss commented on a change in pull request #769:
Add Python 3 compatibility to bin/cordova_plist_to_config_xml
Posted by GitBox <gi...@apache.org>.
cclauss commented on a change in pull request #769: Add Python 3 compatibility to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380873477
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -106,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml', 'lastKnownFileType = text.xml')
- print(line, end='')
+ print(line, end=' ')
Review comment:
To put a space between each line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org