You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/08/25 23:49:15 UTC
Review Request 25039: SAMZA-393
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25039/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-393
https://issues.apache.org/jira/browse/SAMZA-393
Repository: samza
Description
-------
turn on log compaction for checkpoint topics. force compression off for checkpoint producer. write a test to verify.
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala f3e954a6ee588fc40d970dee23e3bbfccbfd2031
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 977330fd60df2327424f193ae5b6f9849ee72b01
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala 34fe6ddb30b75a8dcca262188eff5832d8f7abf0
Diff: https://reviews.apache.org/r/25039/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 25039: SAMZA-388
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25039/#review51531
-----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala
<https://reviews.apache.org/r/25039/#comment89944>
remove the () after Properties?
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala
<https://reviews.apache.org/r/25039/#comment89945>
remove space.
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala
<https://reviews.apache.org/r/25039/#comment89946>
remove "java.util.". "new Properties" is sufficient because already import java.util.Properties.
- Yan Fang
On Aug. 25, 2014, 9:49 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25039/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 9:49 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-388
> https://issues.apache.org/jira/browse/SAMZA-388
>
>
> Repository: samza
>
>
> Description
> -------
>
> turn on log compaction for checkpoint topics. force compression off for checkpoint producer. write a test to verify.
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala f3e954a6ee588fc40d970dee23e3bbfccbfd2031
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 977330fd60df2327424f193ae5b6f9849ee72b01
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala 34fe6ddb30b75a8dcca262188eff5832d8f7abf0
>
> Diff: https://reviews.apache.org/r/25039/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 25039: SAMZA-388
Posted by Chris Riccomini <cr...@apache.org>.
> On Aug. 26, 2014, 6:43 p.m., Chinmay Soman wrote:
> > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala, line 58
> > <https://reviews.apache.org/r/25039/diff/2/?file=669387#file669387line58>
> >
> > Should we make this configurable ?
Opened SAMZA-399 since this is already committed. Will fix.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25039/#review51563
-----------------------------------------------------------
On Aug. 26, 2014, 4:01 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25039/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 4:01 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-388
> https://issues.apache.org/jira/browse/SAMZA-388
>
>
> Repository: samza
>
>
> Description
> -------
>
> misc fixes from rb
>
>
> Merge branch 'master' into SAMZA-393
>
>
> turn on log compaction for checkpoint topics. force compression off for checkpoint producer. write a test to verify.
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala f3e954a6ee588fc40d970dee23e3bbfccbfd2031
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 977330fd60df2327424f193ae5b6f9849ee72b01
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala 34fe6ddb30b75a8dcca262188eff5832d8f7abf0
>
> Diff: https://reviews.apache.org/r/25039/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 25039: SAMZA-388
Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25039/#review51563
-----------------------------------------------------------
Ship it!
Minor comment. Looks good otherwise.
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala
<https://reviews.apache.org/r/25039/#comment89974>
Should we make this configurable ?
- Chinmay Soman
On Aug. 26, 2014, 4:01 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25039/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 4:01 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-388
> https://issues.apache.org/jira/browse/SAMZA-388
>
>
> Repository: samza
>
>
> Description
> -------
>
> misc fixes from rb
>
>
> Merge branch 'master' into SAMZA-393
>
>
> turn on log compaction for checkpoint topics. force compression off for checkpoint producer. write a test to verify.
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala f3e954a6ee588fc40d970dee23e3bbfccbfd2031
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 977330fd60df2327424f193ae5b6f9849ee72b01
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala 34fe6ddb30b75a8dcca262188eff5832d8f7abf0
>
> Diff: https://reviews.apache.org/r/25039/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 25039: SAMZA-388
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25039/
-----------------------------------------------------------
(Updated Aug. 26, 2014, 4:01 p.m.)
Review request for samza.
Bugs: SAMZA-388
https://issues.apache.org/jira/browse/SAMZA-388
Repository: samza
Description (updated)
-------
misc fixes from rb
Merge branch 'master' into SAMZA-393
turn on log compaction for checkpoint topics. force compression off for checkpoint producer. write a test to verify.
Diffs (updated)
-----
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala f3e954a6ee588fc40d970dee23e3bbfccbfd2031
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 977330fd60df2327424f193ae5b6f9849ee72b01
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala 34fe6ddb30b75a8dcca262188eff5832d8f7abf0
Diff: https://reviews.apache.org/r/25039/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 25039: SAMZA-388
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25039/
-----------------------------------------------------------
(Updated Aug. 25, 2014, 9:49 p.m.)
Review request for samza.
Summary (updated)
-----------------
SAMZA-388
Bugs: SAMZA-388
https://issues.apache.org/jira/browse/SAMZA-388
Repository: samza
Description
-------
turn on log compaction for checkpoint topics. force compression off for checkpoint producer. write a test to verify.
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala f3e954a6ee588fc40d970dee23e3bbfccbfd2031
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala 977330fd60df2327424f193ae5b6f9849ee72b01
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala 34fe6ddb30b75a8dcca262188eff5832d8f7abf0
Diff: https://reviews.apache.org/r/25039/diff/
Testing
-------
Thanks,
Chris Riccomini