You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by "zhijiang (JIRA)" <ji...@apache.org> on 2019/05/13 08:56:00 UTC

[jira] [Created] (FLINK-12497) Refactor the start method of ConnectionManager

zhijiang created FLINK-12497:
--------------------------------

             Summary: Refactor the start method of ConnectionManager
                 Key: FLINK-12497
                 URL: https://issues.apache.org/jira/browse/FLINK-12497
             Project: Flink
          Issue Type: Sub-task
          Components: Runtime / Network
            Reporter: zhijiang
            Assignee: zhijiang


In current `ConnectionManager#start(ResultPartitionProvider, TaskEventDispatcher)`, the parameters in start are only reasonable for `NettyConnectionManager` implementation, reductant for `LocalConnectionManager`. 

We could put these parameters in the constructor of `NettyConnectionManager`, then `ConnectionManager#start()` would be more cleaner for both implementations. And it also bring benefits for calling start in `NetworkEnvironment` which does not need to maintain private `TaskEventDispatcher`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)