You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/11 09:48:25 UTC
Review Request: Added some ASSERT_/EXPECT_ macros for Option, Try,
and Result.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7545/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/tests/cgroups_tests.cpp 5c0548b7b4392321d2c15b96cc36f651e7e7f477
src/tests/utils.hpp 63f8d881da9b06f941bb104546ae03c47d140de0
Diff: https://reviews.apache.org/r/7545/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added some ASSERT_/EXPECT_ macros for Option, Try,
and Result.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7545/#review12369
-----------------------------------------------------------
Ship it!
Love it!
src/tests/utils.hpp
<https://reviews.apache.org/r/7545/#comment26175>
Should we put these templated functions inside a namespace?
- Ben Mahler
On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7545/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2012, 7:48 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp 5c0548b7b4392321d2c15b96cc36f651e7e7f477
> src/tests/utils.hpp 63f8d881da9b06f941bb104546ae03c47d140de0
>
> Diff: https://reviews.apache.org/r/7545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added some ASSERT_/EXPECT_ macros for Option, Try,
and Result.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7545/#review12339
-----------------------------------------------------------
Ship it!
this definitely cleans up test code. thanx!
- Vinod Kone
On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7545/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2012, 7:48 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp 5c0548b7b4392321d2c15b96cc36f651e7e7f477
> src/tests/utils.hpp 63f8d881da9b06f941bb104546ae03c47d140de0
>
> Diff: https://reviews.apache.org/r/7545/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>