You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/11 20:42:33 UTC

[GitHub] [arrow-rs] tustvold commented on pull request #3510: Make consistent behavior on zeros equality on floating point types

tustvold commented on PR #3510:
URL: https://github.com/apache/arrow-rs/pull/3510#issuecomment-1379461102

   I'm not sure about this, as it means we no longer are comparing with respect to a standard predicate but one of our own devising. Why special case zero, and not other values like NaNs?
   
   I'd also be interested to know what impact this has on benchmarks.
   
   FWIW If we do make this change, we will need to make changes to normalise within the row format, along with potentially in other places also. Nothing insurmountable, just noting it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org