You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "ChineseTony (via GitHub)" <gi...@apache.org> on 2024/10/30 16:49:59 UTC
[PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
ChineseTony opened a new pull request, #8880:
URL: https://github.com/apache/rocketmq/pull/8880
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #issue_id
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
Posted by "ChineseTony (via GitHub)" <gi...@apache.org>.
ChineseTony commented on PR #8880:
URL: https://github.com/apache/rocketmq/pull/8880#issuecomment-2451105242
i think is't using HashMap ok ,it just lock in put value, but in more times just get value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8880:
URL: https://github.com/apache/rocketmq/pull/8880#issuecomment-3716803142
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8880:
URL: https://github.com/apache/rocketmq/pull/8880#issuecomment-3731102589
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
Posted by "ChineseTony (via GitHub)" <gi...@apache.org>.
ChineseTony commented on PR #8880:
URL: https://github.com/apache/rocketmq/pull/8880#issuecomment-2448949481
ok, I will chage this code
```java
private boolean isFieldNullable(Field field) {
return ConcurrentHashMapUtils.computeIfAbsent(NULLABLE_FIELD_CACHE, field, input -> {
Annotation annotation = input.getAnnotation(CFNotNull.class);
return annotation == null;
});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #8880: [ISSUE #8879] reduce seach key times in method,to import performance
URL: https://github.com/apache/rocketmq/pull/8880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
Posted by "ChineseTony (via GitHub)" <gi...@apache.org>.
ChineseTony commented on PR #8880:
URL: https://github.com/apache/rocketmq/pull/8880#issuecomment-2572443112
ok,thanks ,but isFieldNullable function can use temp variable to save and reture the value ,Don't need search key twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
Posted by "qianye1001 (via GitHub)" <gi...@apache.org>.
qianye1001 commented on PR #8880:
URL: https://github.com/apache/rocketmq/pull/8880#issuecomment-2448884733
If refactoring this part of the code, it might be simpler to use ConcurrentHashMap instead of HashMap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #8879] reduce seach key times in method,to import performance [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8880:
URL: https://github.com/apache/rocketmq/pull/8880#issuecomment-2447866274
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8880?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 47.55%. Comparing base [(`dd62ed0`)](https://app.codecov.io/gh/apache/rocketmq/commit/dd62ed0f3b16919adec5d5eece21a1050dc9c5a0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`50f53b1`)](https://app.codecov.io/gh/apache/rocketmq/commit/50f53b1cb2ba6cf26d7e23077fd10945ca554aa9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 3 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #8880 +/- ##
=============================================
- Coverage 47.61% 47.55% -0.07%
+ Complexity 11752 11734 -18
=============================================
Files 1304 1304
Lines 91043 91053 +10
Branches 11675 11676 +1
=============================================
- Hits 43354 43300 -54
- Misses 42352 42411 +59
- Partials 5337 5342 +5
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8880?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org