You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/09/02 15:30:07 UTC
Review Request 25247: String datePattern moved to BaseTestClass in
falcon-regression
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25247/
-----------------------------------------------------------
Review request for Falcon.
Bugs: falcon-657
https://issues.apache.org/jira/browse/falcon-657
Repository: falcon-git
Description
-------
String datePattern moved to BaseTestClass
Diffs
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java a951da7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java fac215f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java 63484c1
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 00f68e6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java d4fab30
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java c4c11cf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java d733cfc
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java 154485f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java 48bf185
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 25456a2
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java 25ef675
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 33d6b07
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 3160c1d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java e324c26
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java 6bb466c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 5e56037
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 02bd254
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java fa02fdf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 838c6d7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java 37aa98c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java 5000746
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java 564637c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedRetentionTest.java 666a62f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java 884862b
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java b1e78d0
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java 71abd95
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java ee7052e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java 6aebbd7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java b7da224
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 89f3686
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java 468692a
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java 7109829
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java f8a9fd6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 697d8bd
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java 458ddc6
Diff: https://reviews.apache.org/r/25247/diff/
Testing
-------
LineageApiTest
Thanks,
Ruslan Ostafiychuk
Re: Review Request 25247: String datePattern moved to BaseTestClass in
falcon-regression
Posted by Raghav Gautam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25247/#review52325
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Sept. 4, 2014, 4:41 a.m., Ruslan Ostafiychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25247/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 4:41 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-657
> https://issues.apache.org/jira/browse/falcon-657
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> String datePattern moved to BaseTestClass
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java a951da7
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java fac215f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java 63484c1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 00f68e6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java d4fab30
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java c4c11cf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java edf3428
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java 636da2c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java 48bf185
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 25456a2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java 25ef675
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 33d6b07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 3160c1d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java e324c26
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java 6bb466c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 5e56037
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 02bd254
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java fa02fdf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 838c6d7
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java 37aa98c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java 0b06823
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java 564637c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedRetentionTest.java 666a62f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java 884862b
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java b1e78d0
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java 71abd95
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java ee7052e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java 6aebbd7
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java 15a2c3c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 89f3686
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java 468692a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java 7109829
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java f8a9fd6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 697d8bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java c82786f
>
> Diff: https://reviews.apache.org/r/25247/diff/
>
>
> Testing
> -------
>
> LineageApiTest
>
>
> Thanks,
>
> Ruslan Ostafiychuk
>
>
Re: Review Request 25247: String datePattern moved to BaseTestClass in
falcon-regression
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25247/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 11:41 a.m.)
Review request for Falcon.
Bugs: falcon-657
https://issues.apache.org/jira/browse/falcon-657
Repository: falcon-git
Description
-------
String datePattern moved to BaseTestClass
Diffs (updated)
-----
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java a951da7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java fac215f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java 63484c1
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 00f68e6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java d4fab30
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java c4c11cf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java edf3428
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java 636da2c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java 48bf185
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 25456a2
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java 25ef675
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 33d6b07
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 3160c1d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java e324c26
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java 6bb466c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 5e56037
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 02bd254
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java fa02fdf
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 838c6d7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java 37aa98c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java 0b06823
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java 564637c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedRetentionTest.java 666a62f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java 884862b
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java b1e78d0
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java 71abd95
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java ee7052e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java 6aebbd7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java 15a2c3c
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 89f3686
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java 468692a
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java 7109829
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java f8a9fd6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 697d8bd
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java c82786f
Diff: https://reviews.apache.org/r/25247/diff/
Testing
-------
LineageApiTest
Thanks,
Ruslan Ostafiychuk
Re: Review Request 25247: String datePattern moved to BaseTestClass in
falcon-regression
Posted by Raghav Gautam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25247/#review52215
-----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
<https://reviews.apache.org/r/25247/#comment90958>
Is this the only date pattern that we use in our tests ?
Consider naming this minuteDatePattern or something like that.
- Raghav Gautam
On Sept. 2, 2014, 6:30 a.m., Ruslan Ostafiychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25247/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 6:30 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-657
> https://issues.apache.org/jira/browse/falcon-657
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> String datePattern moved to BaseTestClass
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java a951da7
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java fac215f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExp_FutureAndLatestTest.java 63484c1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 00f68e6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java d4fab30
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java c4c11cf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java d733cfc
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java 154485f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java 48bf185
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java 25456a2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java 25ef675
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java 33d6b07
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 3160c1d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java e324c26
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java 6bb466c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java 5e56037
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 02bd254
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java fa02fdf
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java 838c6d7
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java 37aa98c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java 5000746
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java 564637c
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedRetentionTest.java 666a62f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java 884862b
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java b1e78d0
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java 71abd95
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java ee7052e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java 6aebbd7
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java b7da224
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 89f3686
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java 468692a
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java 7109829
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java f8a9fd6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 697d8bd
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java 458ddc6
>
> Diff: https://reviews.apache.org/r/25247/diff/
>
>
> Testing
> -------
>
> LineageApiTest
>
>
> Thanks,
>
> Ruslan Ostafiychuk
>
>