You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Thomas (JIRA)" <ji...@apache.org> on 2007/04/10 07:24:32 UTC

[jira] Created: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates

wicket:head contributions from panel markup should be parsed to remove duplicates 
----------------------------------------------------------------------------------

                 Key: WICKET-456
                 URL: https://issues.apache.org/jira/browse/WICKET-456
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.3
            Reporter: Peter Thomas
            Priority: Minor


When using wicket:head to contribute head entries, when multiple panels are used in a page, the HTML head section ends up with duplicate entries if some of the panels share common resources.

Of course there is no problem if you use HeaderContributor in the code instead.

Nabble discussion link:

http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag closed WICKET-456.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

> wicket:head contributions from panel markup should be parsed to remove duplicates 
> ----------------------------------------------------------------------------------
>
>                 Key: WICKET-456
>                 URL: https://issues.apache.org/jira/browse/WICKET-456
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Peter Thomas
>         Assigned To: Matej Knopp
>            Priority: Minor
>             Fix For: 1.3
>
>
> When using wicket:head to contribute head entries, when multiple panels are used in a page, the HTML head section ends up with duplicate entries if some of the panels share common resources.
> Of course there is no problem if you use HeaderContributor in the code instead.
> Nabble discussion link:
> http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495278 ] 

Matej Knopp commented on WICKET-456:
------------------------------------

I'm -1 on this and if noone objects I'll close this as won't fix. We already filter duplicate contribution for panels of the same class. If anyone needs to filter contributions from component of different classes there is IHeaderReponse for that. 

> wicket:head contributions from panel markup should be parsed to remove duplicates 
> ----------------------------------------------------------------------------------
>
>                 Key: WICKET-456
>                 URL: https://issues.apache.org/jira/browse/WICKET-456
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Peter Thomas
>            Priority: Minor
>
> When using wicket:head to contribute head entries, when multiple panels are used in a page, the HTML head section ends up with duplicate entries if some of the panels share common resources.
> Of course there is no problem if you use HeaderContributor in the code instead.
> Nabble discussion link:
> http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates

Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Knopp reassigned WICKET-456:
----------------------------------

    Assignee: Matej Knopp

> wicket:head contributions from panel markup should be parsed to remove duplicates 
> ----------------------------------------------------------------------------------
>
>                 Key: WICKET-456
>                 URL: https://issues.apache.org/jira/browse/WICKET-456
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Peter Thomas
>         Assigned To: Matej Knopp
>            Priority: Minor
>
> When using wicket:head to contribute head entries, when multiple panels are used in a page, the HTML head section ends up with duplicate entries if some of the panels share common resources.
> Of course there is no problem if you use HeaderContributor in the code instead.
> Nabble discussion link:
> http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-456) wicket:head contributions from panel markup should be parsed to remove duplicates

Posted by "Peter Thomas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495284 ] 

Peter Thomas commented on WICKET-456:
-------------------------------------

I'm okay with not fixing this, HeaderContributor is working fine for me.

> wicket:head contributions from panel markup should be parsed to remove duplicates 
> ----------------------------------------------------------------------------------
>
>                 Key: WICKET-456
>                 URL: https://issues.apache.org/jira/browse/WICKET-456
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Peter Thomas
>         Assigned To: Matej Knopp
>            Priority: Minor
>
> When using wicket:head to contribute head entries, when multiple panels are used in a page, the HTML head section ends up with duplicate entries if some of the panels share common resources.
> Of course there is no problem if you use HeaderContributor in the code instead.
> Nabble discussion link:
> http://www.nabble.com/Duplicate-wicket%3Ahead-contributed-entries-with-multiple-panels-on-a-page-tf3548384.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.