You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2023/02/01 19:36:22 UTC
[GitHub] [trafficserver] zwoop opened a new pull request, #9355: Upgrades master branch to use clang-format v15.0.7
zwoop opened a new pull request, #9355:
URL: https://github.com/apache/trafficserver/pull/9355
In addition to the upgrade to v15.0.7, with its new features and fixes, this also adds binaries for aarch64 platforms for both Linux and macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on a diff in pull request #9355: Upgrades master branch to use clang-format v15.0.7
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #9355:
URL: https://github.com/apache/trafficserver/pull/9355#discussion_r1093845952
##########
iocore/dns/SplitDNS.cc:
##########
@@ -407,7 +407,7 @@ SplitDNSRecord::ProcessDomainSrchList(char *val)
for (int i = 0; i < numTok; i++) {
const char *current = pTok[i];
- int cnt = sz += strlen(current);
+ int cnt = sz += strlen(current);
Review Comment:
Yeh, there are still imperfections :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #9355: Upgrades master branch to use clang-format v15.0.7
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #9355:
URL: https://github.com/apache/trafficserver/pull/9355#discussion_r1093823180
##########
iocore/dns/SplitDNS.cc:
##########
@@ -407,7 +407,7 @@ SplitDNSRecord::ProcessDomainSrchList(char *val)
for (int i = 0; i < numTok; i++) {
const char *current = pTok[i];
- int cnt = sz += strlen(current);
+ int cnt = sz += strlen(current);
Review Comment:
This is an interesting change. Most of the other changes add alignment with the previous `=` or whatever, this removes it. (This isn't a problem, just something that caught my eye.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9355: Upgrades master branch to use clang-format v15.0.7
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9355:
URL: https://github.com/apache/trafficserver/pull/9355#issuecomment-1412721731
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9355: Upgrades master branch to use clang-format v15.0.7
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9355:
URL: https://github.com/apache/trafficserver/pull/9355#issuecomment-1412877508
And I do definitely like having the arm64 clang-format binaries. That makes running clang-format much quicker on my system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9355: Upgrades master branch to use clang-format v15.0.7
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9355:
URL: https://github.com/apache/trafficserver/pull/9355#issuecomment-1412726425
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop merged pull request #9355: Upgrades master branch to use clang-format v15.0.7
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop merged PR #9355:
URL: https://github.com/apache/trafficserver/pull/9355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org