You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/16 16:43:36 UTC

[GitHub] [incubator-superset] zuzana-vej opened a new issue #11304: Markdown resize nor working when Markdown added into new tab as full width

zuzana-vej opened a new issue #11304:
URL: https://github.com/apache/incubator-superset/issues/11304


   In some cases, markdown resize doesn't work. Specifically when markdown is being added into new tab.
   
   ### Expected results
   Should be able to resize Markdown.
   
   ### Actual results
   
   Can't resize the Markdown.
   
   #### Screenshots
   
   ![Screen Shot 2020-10-16 at 9 41 41 AM](https://user-images.githubusercontent.com/61221714/96285438-d0a4c300-0f93-11eb-8220-cd7e57e4d9f5.png)
   
   #### How to reproduce the bug
   
   1. Go to Dashboard edit mode
   2. Add new tab at the bottom of a page (or add tab within a tab)
   3. Add Markdown into the tab
   4. Markdown will be full width by default, and the resize (in right corner) doesn't work
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: master
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] zuzana-vej commented on issue #11304: Markdown resize not working when Markdown added into new tab as full width

Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11304:
URL: https://github.com/apache/incubator-superset/issues/11304#issuecomment-721899956


   Yes! Verified. Thank you! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] junlincc commented on issue #11304: Markdown resize not working when Markdown added into new tab as full width

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11304:
URL: https://github.com/apache/incubator-superset/issues/11304#issuecomment-713598390


   @kkucharc


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] zuzana-vej edited a comment on issue #11304: Markdown resize not working when Markdown added into new tab as full width

Posted by GitBox <gi...@apache.org>.
zuzana-vej edited a comment on issue #11304:
URL: https://github.com/apache/incubator-superset/issues/11304#issuecomment-721899956


   Yes! Verified. Thank you! 
   
   I saw a PR in last few days which changed the default size to the markdown is not placed as full size. Which probably fixed this (previously it was pasting full size in that specific scenario)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] junlincc commented on issue #11304: Markdown resize not working when Markdown added into new tab as full width

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11304:
URL: https://github.com/apache/incubator-superset/issues/11304#issuecomment-719030334


   @kkucharc tested on latest master, still not working properly. 
   resizing works at the dashboard level, but not tab level. 
   ![testmarkdown](https://user-images.githubusercontent.com/67837651/97633964-29dc1000-19f2-11eb-81c2-f0230abb1143.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] zuzana-vej closed issue #11304: Markdown resize not working when Markdown added into new tab as full width

Posted by GitBox <gi...@apache.org>.
zuzana-vej closed issue #11304:
URL: https://github.com/apache/incubator-superset/issues/11304


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] zuzana-vej commented on issue #11304: Markdown resize not working when Markdown added into new tab as full width

Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11304:
URL: https://github.com/apache/incubator-superset/issues/11304#issuecomment-719047517


   Agreed. I tested this yesterday too. This is some corner case which isn't fixed yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11304: Markdown resize nor working when Markdown added into new tab as full width

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11304:
URL: https://github.com/apache/incubator-superset/issues/11304#issuecomment-710202020


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org