You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "AlvaroStream (via GitHub)" <gi...@apache.org> on 2023/06/28 13:10:05 UTC
[GitHub] [pulsar-site] AlvaroStream opened a new pull request, #625: [improve][doc] Subscription replication doesn't replicate the type
AlvaroStream opened a new pull request, #625:
URL: https://github.com/apache/pulsar-site/pull/625
There can be a corner case where 2 consumer subscribe with different type of subscription on each cluster.
The only thing replicated is information about the subscription. Not the type.
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
-->
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] AlvaroStream commented on a diff in pull request #625: [improve][doc] Subscription replication doesn't replicate the type
Posted by "AlvaroStream (via GitHub)" <gi...@apache.org>.
AlvaroStream commented on code in PR #625:
URL: https://github.com/apache/pulsar-site/pull/625#discussion_r1250381357
##########
versioned_docs/version-3.0.x/administration-geo.md:
##########
@@ -227,6 +227,12 @@ If you want to use replicated subscriptions in Pulsar:
.replicateSubscriptionState(true)
.subscribe();
```
+:::note
+
+* Replication type is not replicated between clusters but determined by the first consumer that connects to the subscription.
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet merged pull request #625: [improve][doc] Subscription replication doesn't replicate the type
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet merged PR #625:
URL: https://github.com/apache/pulsar-site/pull/625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #625: [improve][doc] Subscription replication doesn't replicate the type
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on code in PR #625:
URL: https://github.com/apache/pulsar-site/pull/625#discussion_r1250025658
##########
versioned_docs/version-3.0.x/administration-geo.md:
##########
@@ -227,6 +227,12 @@ If you want to use replicated subscriptions in Pulsar:
.replicateSubscriptionState(true)
.subscribe();
```
+:::note
+
+* Replication type is not replicated between clusters but determined by the first consumer that connects to the subscription.
Review Comment:
```suggestion
* Replication type is not replicated between clusters. However, it's determined by the first consumer that connects to the subscription.
```
Can we break this long sentence to improve readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] AlvaroStream commented on a diff in pull request #625: [improve][doc] Subscription replication doesn't replicate the type
Posted by "AlvaroStream (via GitHub)" <gi...@apache.org>.
AlvaroStream commented on code in PR #625:
URL: https://github.com/apache/pulsar-site/pull/625#discussion_r1250986587
##########
versioned_docs/version-3.0.x/administration-geo.md:
##########
@@ -227,6 +227,12 @@ If you want to use replicated subscriptions in Pulsar:
.replicateSubscriptionState(true)
.subscribe();
```
+:::note
+
+* Replication type is not replicated between clusters. However, it's determined by the first consumer that connects to the subscription.
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #625: [improve][doc] Subscription replication doesn't replicate the type
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #625:
URL: https://github.com/apache/pulsar-site/pull/625#issuecomment-1612475737
@gaoran10
Could you please help review this PR from a technical perspective? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] hangc0276 commented on a diff in pull request #625: [improve][doc] Subscription replication doesn't replicate the type
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on code in PR #625:
URL: https://github.com/apache/pulsar-site/pull/625#discussion_r1250955811
##########
versioned_docs/version-3.0.x/administration-geo.md:
##########
@@ -227,6 +227,12 @@ If you want to use replicated subscriptions in Pulsar:
.replicateSubscriptionState(true)
.subscribe();
```
+:::note
+
+* Replication type is not replicated between clusters. However, it's determined by the first consumer that connects to the subscription.
Review Comment:
Subscription Type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org