You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Pratik Raj <no...@github.com> on 2020/03/12 08:55:52 UTC

[apache/incubator-teaclave] optimization debian package manager tweaks (#239)

By default, Ubuntu or Debian based &quot;apt&quot; or &quot;apt-get&quot; system installs recommended but not suggested packages .

By passing &quot;--no-install-recommends&quot; option, the user lets apt-get know not to consider recommended packages as a dependency to install.

This results in smaller downloads and installation of packages .

Refer to blog at [Ubuntu Blog](https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends) .

Signed-off-by: Pratik Raj &lt;rajpratik71@gmail.com&gt;

## Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

## Type of change (select applied and DELETE the others)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates

## How Has This Been Tested?

## Checklist (check ALL before submitting PR, even not applicable)

- [ ] Fork the repo and create your branch from `master`.
- [ ] If you&#39;ve added code that should be tested, add tests.
- [ ] If you&#39;ve changed APIs, update the documentation.
- [ ] Ensure the tests pass (see CI results).
- [ ] Make sure your code lints/format.

You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/239

-- Commit Summary --

  * optimization debian package manager tweaks

-- File Changes --

    M CMakeLists.txt (2)
    M docker/build.ubuntu-1604.Dockerfile (10)
    M docker/build.ubuntu-1804.Dockerfile (8)
    M docker/fns-rt.ubuntu-1604.Dockerfile (2)
    M docker/fns-rt.ubuntu-1804.Dockerfile (2)
    M docker/kms-rt.ubuntu-1604.Dockerfile (2)
    M docker/kms-rt.ubuntu-1804.Dockerfile (2)
    M docker/tdfs-rt.ubuntu-1604.Dockerfile (2)
    M docker/tdfs-rt.ubuntu-1804.Dockerfile (2)
    M docker/tms-rt.ubuntu-1604.Dockerfile (2)
    M docker/tms-rt.ubuntu-1804.Dockerfile (2)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/239.patch
https://github.com/apache/incubator-teaclave/pull/239.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/239

Re: [apache/incubator-teaclave] optimization debian package manager tweaks (#239)

Posted by Mingshen Sun <no...@github.com>.
Any updates on this PR? Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/239#issuecomment-604801278

Re: [apache/incubator-teaclave] optimization debian package manager tweaks (#239)

Posted by Mingshen Sun <no...@github.com>.
Thanks for the PR. 

- Since I'm not sure if some of the dependencies are from the "recommended packages", have you compiled the project with the updated docker image (which with `--no-install-recommends` on)?
- We are working on the `develop` branch right now. If you want to make any changes about this, could you please submit PR based on the `develop` branch? Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/239#issuecomment-598471785

Re: [apache/incubator-teaclave] optimization debian package manager tweaks (#239)

Posted by Mingshen Sun <no...@github.com>.
Since this PR is stale, I'm closing it. Feel free to reopen or create a new one if there is any update.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/239#issuecomment-605198253

Re: [apache/incubator-teaclave] optimization debian package manager tweaks (#239)

Posted by Mingshen Sun <no...@github.com>.
Closed #239.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/239#event-3173549984