[GitHub] [airflow] josh-fell commented on a change in pull request #21385: Enable asynchronous job submission in BigQuery Insert Job

[GitBox <gi...@apache.org>]

josh-fell commented on a change in pull request #21385:
URL: https://github.com/apache/airflow/pull/21385#discussion_r800864931



##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -1498,6 +1498,7 @@ def insert_job(
         job_id: Optional[str] = None,
         project_id: Optional[str] = None,
         location: Optional[str] = None,
+        is_async: Optional[bool] = False,

Review comment:
       ```suggestion
           is_async: bool = False,
   ```

##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -1514,6 +1515,8 @@ def insert_job(
             characters. If not provided then uuid will be generated.
         :param project_id: Google Cloud Project where the job is running
         :param location: location the job is running
+        :param is_async: specify whether to insert job in asynchronous mode
+        :type is_async: bool

Review comment:
       ```suggestion
   ```
   The `:type:` directives are no longer needed. Sphinx can now directly infer from the type annotations rather than the docstrings for the API documentation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org