You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by markflyhigh <gi...@git.apache.org> on 2016/11/10 22:38:33 UTC
[GitHub] incubator-beam pull request #1343: Support @ValidatesRunner(RunnableOnServic...
GitHub user markflyhigh opened a pull request:
https://github.com/apache/incubator-beam/pull/1343
Support @ValidatesRunner(RunnableOnService) in Python
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
- introduce annotation "ValidatesRunner" (same as RunnableOnService in Java) for tests that run against runner.
- support "test_options" argument in command line used to generate customized pipeline options for tests with @ValidatesRunner tag.
- potentially support capability metrix testing using parametrized marker(annotation).
- new test dependency Pytest is introduced to handle marker(annotation) and test suites.
TODO: modify some existing unit tests to @ValidatesRunner tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markflyhigh/incubator-beam support-validate-runner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1343
----
commit 50fbce83e77481ea960ef9d190c396d02d090cae
Author: Mark Liu <ma...@markliu-macbookpro.roam.corp.google.com>
Date: 2016-11-10T19:57:21Z
Support @ValidatesRunner Tests
commit b172892a8d1cb5a9a14aa7dc46531d147862a723
Author: Mark Liu <ma...@markliu-macbookpro.roam.corp.google.com>
Date: 2016-11-10T21:34:36Z
Add pytest to setup.py test dependency list
commit fe9306ee3239739efaf9c0603ffc7236083bc4dc
Author: Mark Liu <ma...@markliu-macbookpro.roam.corp.google.com>
Date: 2016-11-10T22:19:10Z
fixup! Fix pylint errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1343: Support @ValidatesRunner(RunnableOnServic...
Posted by markflyhigh <gi...@git.apache.org>.
Github user markflyhigh closed the pull request at:
https://github.com/apache/incubator-beam/pull/1343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---