You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2012/12/11 13:11:32 UTC

Review Request: [EC2 Query API] AttachVolume fails with 'Permission Denied: Invalid Signature' error.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8480/
-----------------------------------------------------------

Review request for cloudstack and Prachi Damle.


Description
-------

In AWSAPI while forming the signature to validate an API, url-encode every parameter name with UTF-8 encoding scheme. 


This addresses bug CLOUDSTACK-197.


Diffs
-----

  awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 4f74873 

Diff: https://reviews.apache.org/r/8480/diff/


Testing
-------

After setting up AWSAPI, using the boto client called
 attach_volume(<volume_id>, <instance_id>, <device>)
Successfully attached the specified volume to the instance


Thanks,

Likitha Shetty


Re: Review Request: [EC2 Query API] AttachVolume fails with 'Permission Denied: Invalid Signature' error.

Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8480/#review15970
-----------------------------------------------------------

Ship it!


Looks correct. Fixes the issue blocking the REST calls.

- Prachi Damle


On Dec. 12, 2012, 10:31 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8480/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 10:31 a.m.)
> 
> 
> Review request for cloudstack and Prachi Damle.
> 
> 
> Description
> -------
> 
> In AWSAPI while forming the signature to validate an API, url-encode every parameter name with UTF-8 encoding scheme. 
> 
> 
> This addresses bug CLOUDSTACK-609.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 4f74873 
> 
> Diff: https://reviews.apache.org/r/8480/diff/
> 
> 
> Testing
> -------
> 
> After setting up AWSAPI, using the boto client called
>  attach_volume(<volume_id>, <instance_id>, <device>)
> Successfully attached the specified volume to the instance
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Re: Review Request: [EC2 Query API] AttachVolume fails with 'Permission Denied: Invalid Signature' error.

Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8480/
-----------------------------------------------------------

(Updated Dec. 12, 2012, 10:31 a.m.)


Review request for cloudstack and Prachi Damle.


Changes
-------

Updating the bug-id


Description
-------

In AWSAPI while forming the signature to validate an API, url-encode every parameter name with UTF-8 encoding scheme. 


This addresses bug CLOUDSTACK-609.


Diffs
-----

  awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 4f74873 

Diff: https://reviews.apache.org/r/8480/diff/


Testing
-------

After setting up AWSAPI, using the boto client called
 attach_volume(<volume_id>, <instance_id>, <device>)
Successfully attached the specified volume to the instance


Thanks,

Likitha Shetty