You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/12 14:07:49 UTC

[GitHub] zentol opened a new pull request #7292: [FLINK-11101][S3] Ban openjdk.jol dependencies

zentol opened a new pull request #7292: [FLINK-11101][S3] Ban openjdk.jol dependencies
URL: https://github.com/apache/flink/pull/7292
 
 
   ## What is the purpose of the change
   
   This PR removes a redundant exclusion for `openjdk.jol` from the presto-s3-filesystem pom, and adds a safeguard via the `maven-enforcer-plugin` to prevent this dependency from showing up in the dependency tree again. This guarantees that the dependency section properly excludes this dependency.
   
   This is a better approach than relying on the shade-plugin configuration since the dependency could still show up in the dependency tree of the project (if the dependency section does note exclude it correctly), which could ring alarm-bells during release testing for no reason.
   
   ## Verifying this change
   
   You can manually verify the effectiveness of the enforcer by removing the `openjdk.jol` exclusion from `presto-hive` and running `mvn-validate`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services