You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "weixiang1862 (via GitHub)" <gi...@apache.org> on 2023/07/21 14:56:04 UTC

[GitHub] [skywalking-showcase] weixiang1862 opened a new pull request, #144: MongoDB monitoring showcase

weixiang1862 opened a new pull request, #144:
URL: https://github.com/apache/skywalking-showcase/pull/144

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646423977

   > How do the metrics charts look like? Do we need to add some traffic reads/writes to the MongoDB?
   The exporter it self can provider some traffic,I will pin a picture when I back.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1645788127

   Main repo need sync ui from booster-ui.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wu-sheng commented on pull request #144: MongoDB monitoring showcase

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646357633

   Wait for @kezhenxu94 and @wankai123 review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646342781

   Could you please build a new ui image? I don't know how to trigger it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wu-sheng merged pull request #144: MongoDB monitoring showcase

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wu-sheng commented on pull request #144: MongoDB monitoring showcase

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646604936

   @wankai123 When you have time, let's bring this to demo env as well.
   
   Doc is hosted, https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-mongodb-monitoring/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wu-sheng commented on pull request #144: MongoDB monitoring showcase

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646344916

   It is automatically built after merged
   
   Now it is there, https://github.com/apache/skywalking/pkgs/container/skywalking%2Fui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1645741060

   > Do you mean UI having issues?
   
   No issue,I think
   
   > Do you mean UI having issues?
   
   No issue, it work on my local with command `npm run dev`.
   May be the image with this tag does not contains the latest code, but it is latest tag I found in registry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wu-sheng commented on pull request #144: MongoDB monitoring showcase

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1645790225

   You could sync through a PR. Update UI sub module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646357414

   It works now, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1645722907

   UI image is not the latest, it shows i18n key now.
   
   ![image](https://github.com/apache/skywalking-showcase/assets/16346644/bba0e62e-11eb-4d14-9c38-b9d8648bc426)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wankai123 commented on a diff in pull request #144: MongoDB monitoring showcase

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1271294518


##########
deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml:
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+{{- define "opentelemetry-config-mongodb-monitor" }}
+{{- if .Values.features.mongodbMonitor.enabled }}
+
+- job_name: mongodb-monitoring
+  scrape_interval: 10s
+  kubernetes_sd_configs:
+    - role: pod
+  relabel_configs:
+    - source_labels: [ __meta_kubernetes_pod_container_name, __meta_kubernetes_pod_container_port_name ]
+      action: keep
+      regex: metrics;metrics

Review Comment:
   @kezhenxu94 Is that possible to override the name? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646554978

   @kezhenxu94 It looks like this, I running it on my local minikube for about 10 hours.
   
   ![image](https://github.com/apache/skywalking-showcase/assets/16346644/845f7541-75b7-45c1-83c9-9c953dca9029)
   
   ![image](https://github.com/apache/skywalking-showcase/assets/16346644/c887e92d-8535-41be-9dec-2dd94f375a06)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on a diff in pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on code in PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1271296983


##########
deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml:
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+{{- define "opentelemetry-config-mongodb-monitor" }}
+{{- if .Values.features.mongodbMonitor.enabled }}
+
+- job_name: mongodb-monitoring
+  scrape_interval: 10s
+  kubernetes_sd_configs:
+    - role: pod
+  relabel_configs:
+    - source_labels: [ __meta_kubernetes_pod_container_name, __meta_kubernetes_pod_container_port_name ]
+      action: keep
+      regex: metrics;metrics

Review Comment:
   I can try to add a `__meta_kubernetes_pod_controller_name` label, then this scrape job can be limited under mongodb case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wankai123 commented on a diff in pull request #144: MongoDB monitoring showcase

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1271293103


##########
deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml:
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+{{- define "opentelemetry-config-mongodb-monitor" }}
+{{- if .Values.features.mongodbMonitor.enabled }}
+
+- job_name: mongodb-monitoring
+  scrape_interval: 10s
+  kubernetes_sd_configs:
+    - role: pod
+  relabel_configs:
+    - source_labels: [ __meta_kubernetes_pod_container_name, __meta_kubernetes_pod_container_port_name ]
+      action: keep
+      regex: metrics;metrics

Review Comment:
   Should better change the container name to another one?



##########
deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml:
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+{{- define "opentelemetry-config-mongodb-monitor" }}
+{{- if .Values.features.mongodbMonitor.enabled }}
+
+- job_name: mongodb-monitoring
+  scrape_interval: 10s
+  kubernetes_sd_configs:
+    - role: pod
+  relabel_configs:
+    - source_labels: [ __meta_kubernetes_pod_container_name, __meta_kubernetes_pod_container_port_name ]
+      action: keep
+      regex: metrics;metrics

Review Comment:
   Should better change the container name to another one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wu-sheng commented on pull request #144: MongoDB monitoring showcase

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1645726167

   Do you mean UI having issues?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1645794191

   > You could sync through a PR. Update UI sub module.
   
   ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wu-sheng commented on a diff in pull request #144: MongoDB monitoring showcase

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1270829644


##########
Makefile.in:
##########
@@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss
 ES_IMAGE_TAG ?= 7.10.2
 
 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap
-SW_OAP_IMAGE_TAG ?= 8b2fe884152d7bb03e0a8ac0753fdc84df541ce9
+SW_OAP_IMAGE_TAG ?= 8a82ac885d29e0fa4df9c3923edd0dc5830cad2c

Review Comment:
   Please retry, the images are ready now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#issuecomment-1646352205

   > It is automatically built after merged
   > 
   > Now it is there, https://github.com/apache/skywalking/pkgs/container/skywalking%2Fui
   
   Ok, thanks. I will try this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] wu-sheng commented on a diff in pull request #144: MongoDB monitoring showcase

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1270794695


##########
Makefile.in:
##########
@@ -29,10 +29,10 @@ ES_IMAGE ?= docker.elastic.co/elasticsearch/elasticsearch-oss
 ES_IMAGE_TAG ?= 7.10.2
 
 SW_OAP_IMAGE ?= ghcr.io/apache/skywalking/oap
-SW_OAP_IMAGE_TAG ?= 8b2fe884152d7bb03e0a8ac0753fdc84df541ce9
+SW_OAP_IMAGE_TAG ?= 8a82ac885d29e0fa4df9c3923edd0dc5830cad2c

Review Comment:
   https://github.com/apache/skywalking/actions/runs/5621499911
   
   You didn't check, this commit doesn't push the image successfully, I just rerun it.
   Let's see.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-showcase] weixiang1862 commented on a diff in pull request #144: MongoDB monitoring showcase

Posted by "weixiang1862 (via GitHub)" <gi...@apache.org>.
weixiang1862 commented on code in PR #144:
URL: https://github.com/apache/skywalking-showcase/pull/144#discussion_r1271293974


##########
deploy/platform/kubernetes/templates/feature-mongodb/opentelemetry-config.yaml:
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+{{- define "opentelemetry-config-mongodb-monitor" }}
+{{- if .Values.features.mongodbMonitor.enabled }}
+
+- job_name: mongodb-monitoring
+  scrape_interval: 10s
+  kubernetes_sd_configs:
+    - role: pod
+  relabel_configs:
+    - source_labels: [ __meta_kubernetes_pod_container_name, __meta_kubernetes_pod_container_port_name ]
+      action: keep
+      regex: metrics;metrics

Review Comment:
   It was hardcoded in chart template, and can't   be replaced by values.yaml, are there other ways to change this name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org