You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/10 04:03:58 UTC

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1404: interpreter/toywasm: update toywasm version

pkarashchenko commented on code in PR #1404:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1404#discussion_r1018631392


##########
interpreters/toywasm/Makefile:
##########
@@ -51,21 +53,17 @@ CSRCS += vec.c
 CSRCS += wasi.c
 CSRCS += xlog.c
 
-CFLAGS += -DTOYWASM_USE_SEPARATE_EXECUTE
-CFLAGS += -DTOYWASM_USE_TAILCALL
-CFLAGS += -DTOYWASM_USE_JUMP_BINARY_SEARCH
-CFLAGS += -DTOYWASM_JUMP_CACHE2_SIZE=4
-CFLAGS += -DTOYWASM_USE_SEPARATE_LOCALS
-CFLAGS += -DTOYWASM_USE_SMALL_CELLS
-CFLAGS += -DTOYWASM_ENABLE_WRITER
+CFLAGS += ${shell $(INCDIR) "$(CC)" $(APPDIR)/interpreters/toywasm/include}

Review Comment:
   Shouldn't we use `INCDIR_PREFIX` instead? Ref https://github.com/apache/incubator-nuttx-apps/pull/1403



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org