You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2017/04/11 23:35:49 UTC

mesos git commit: Revert "Removed unnecesary break statements in local approver."

Repository: mesos
Updated Branches:
  refs/heads/master 559066638 -> 11486d4ab


Revert "Removed unnecesary break statements in local approver."

This reverts commit 76d42c3bb8404b68656dfff4ed31cff9750f3e65.


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/11486d4a
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/11486d4a
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/11486d4a

Branch: refs/heads/master
Commit: 11486d4abd438fefd9f7e352d41798a444be40c5
Parents: 5590666
Author: Jie Yu <yu...@gmail.com>
Authored: Tue Apr 11 16:35:20 2017 -0700
Committer: Jie Yu <yu...@gmail.com>
Committed: Tue Apr 11 16:35:20 2017 -0700

----------------------------------------------------------------------
 src/common/validation.cpp | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/11486d4a/src/common/validation.cpp
----------------------------------------------------------------------
diff --git a/src/common/validation.cpp b/src/common/validation.cpp
index 9c4f1de..544d3a0 100644
--- a/src/common/validation.cpp
+++ b/src/common/validation.cpp
@@ -16,8 +16,6 @@
 
 #include "common/validation.hpp"
 
-#include <limits.h>
-
 #include <algorithm>
 #include <cctype>
 
@@ -39,19 +37,13 @@ Option<Error> validateID(const string& id)
     return Error("ID must not be empty");
   }
 
-  if (id.length() > NAME_MAX) {
-    return Error(
-        "ID must not be greater than " +
-        stringify(NAME_MAX) + " characters");
-  }
-
   // The ID cannot be exactly these special path components.
   if (id == "." || id == "..") {
     return Error("'" + id + "' is disallowed");
   }
 
   // Rules on invalid characters in the ID:
-  // - Control characters are obviously not allowed.
+  // - Control charaters are obviously not allowed.
   // - Slashes are disallowed as IDs are likely mapped to directories in Mesos.
   auto invalidCharacter = [](char c) {
     return iscntrl(c) ||