[GitHub] raffas opened a new pull request #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined

[GitBox <gi...@apache.org>]

raffas opened a new pull request #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined
URL: https://github.com/apache/incubator-superset/pull/4395
 
 
   I've found the cause of this behaviour of bug #4391
   This seems to be related to the patch #4316. 
   
   The function query_obj in FilterBoxViz return always None. FilterBox is using the new cache system. self.run_extra_query() is executed correctly, but  after that self.query_obj() will be called, passing None to the function get_df_payload(), so no payload.data will be passed to FilterBox itself
   
   This patch call explicity self.filter_query_obj() in query_obj() function
   
   I'm new to SuperSet and the caching system that it's implemented. Maybe this is not the best fix but I'm surely missing some things about how the new cache work.
   
   Debugging the code run_extra_query() seems to be called two times, one from the constructor and the other from the method get_df_payload(). The query will be executed two times. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services