You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "haifxu (via GitHub)" <gi...@apache.org> on 2023/03/29 02:47:19 UTC
[GitHub] [inlong] haifxu opened a new pull request, #7721: [INLONG-6672][Manager] Add suspend and restart command
haifxu opened a new pull request, #7721:
URL: https://github.com/apache/inlong/pull/7721
### Prepare a Pull Request
- Fixes #6672
### Motivation
Add `inlongctl` status management for the group.
### Modifications
1. Add `suspend` and `restart` commands.
2. Modify the `suspendProcess` return type for the manager client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] haifxu commented on a diff in pull request #7721: [INLONG-6672][Manager] Add suspend and restart command
Posted by "haifxu (via GitHub)" <gi...@apache.org>.
haifxu commented on code in PR #7721:
URL: https://github.com/apache/inlong/pull/7721#discussion_r1151497145
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/RestartCommand.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli;
+
+import com.beust.jcommander.Parameter;
+import com.beust.jcommander.Parameters;
+import org.apache.inlong.manager.client.api.InlongClient;
+import org.apache.inlong.manager.client.api.InlongGroup;
+import org.apache.inlong.manager.client.api.InlongGroupContext;
+import org.apache.inlong.manager.client.cli.util.ClientUtils;
+import org.apache.inlong.manager.common.enums.SimpleGroupStatus;
+
+import java.util.List;
+
+/**
+ * Restart inlong group
+ */
+@Parameters(commandDescription = "Restart resource by group id")
+public class RestartCommand extends AbstractCommand {
+
+ @Parameter()
+ private List<String> params;
+
+ public RestartCommand() {
+ super("restart");
+ jcommander.addCommand("group", new RestartCommand.RestartGroup());
+ }
+
+ @Parameters(commandDescription = "Restart the inlong group task")
+ private static class RestartGroup extends AbstractCommandRunner {
+
+ @Parameter()
+ private List<String> params;
+
+ @Parameter(names = {"--group", "-g"}, required = true, description = "inlong group id")
+ private String inlongGroupId;
+
+ @Override
+ void run() throws Exception {
+ try {
+ InlongClient inlongClient = ClientUtils.getClient();
+ InlongGroup group = inlongClient.getGroup(inlongGroupId);
+ InlongGroupContext context = group.restart();
+ if (SimpleGroupStatus.STARTED.equals(context.getStatus())) {
Review Comment:
Done.
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/RestartCommand.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli;
+
+import com.beust.jcommander.Parameter;
+import com.beust.jcommander.Parameters;
+import org.apache.inlong.manager.client.api.InlongClient;
+import org.apache.inlong.manager.client.api.InlongGroup;
+import org.apache.inlong.manager.client.api.InlongGroupContext;
+import org.apache.inlong.manager.client.cli.util.ClientUtils;
+import org.apache.inlong.manager.common.enums.SimpleGroupStatus;
+
+import java.util.List;
+
+/**
+ * Restart inlong group
+ */
+@Parameters(commandDescription = "Restart resource by group id")
+public class RestartCommand extends AbstractCommand {
+
+ @Parameter()
+ private List<String> params;
+
+ public RestartCommand() {
+ super("restart");
+ jcommander.addCommand("group", new RestartCommand.RestartGroup());
+ }
+
+ @Parameters(commandDescription = "Restart the inlong group task")
+ private static class RestartGroup extends AbstractCommandRunner {
+
+ @Parameter()
+ private List<String> params;
+
+ @Parameter(names = {"--group", "-g"}, required = true, description = "inlong group id")
+ private String inlongGroupId;
+
+ @Override
+ void run() throws Exception {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7721: [INLONG-6672][Manager] Add suspend and restart command
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7721:
URL: https://github.com/apache/inlong/pull/7721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] haifxu commented on a diff in pull request #7721: [INLONG-6672][Manager] Add suspend and restart command
Posted by "haifxu (via GitHub)" <gi...@apache.org>.
haifxu commented on code in PR #7721:
URL: https://github.com/apache/inlong/pull/7721#discussion_r1151456957
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/SuspendCommand.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli;
+
+import com.beust.jcommander.Parameter;
+import com.beust.jcommander.Parameters;
+import org.apache.inlong.manager.client.api.InlongClient;
+import org.apache.inlong.manager.client.api.InlongGroup;
+import org.apache.inlong.manager.client.api.InlongGroupContext;
+import org.apache.inlong.manager.client.cli.util.ClientUtils;
+import org.apache.inlong.manager.common.enums.SimpleGroupStatus;
+
+import java.util.List;
+
+/**
+ * Suspend inlong group
+ */
+@Parameters(commandDescription = "Suspend resource by group id")
+public class SuspendCommand extends AbstractCommand {
+
+ @Parameter()
+ private List<String> params;
+
+ public SuspendCommand() {
+ super("suspend");
+ jcommander.addCommand("group", new SuspendCommand.SuspendGroup());
+ }
+
+ @Parameters(commandDescription = "Suspend the inlong group task")
+ private static class SuspendGroup extends AbstractCommandRunner {
+
+ @Parameter()
+ private List<String> params;
+
+ @Parameter(names = {"--group", "-g"}, required = true, description = "inlong group id")
+ private String inlongGroupId;
+
+ @Override
+ void run() throws Exception {
+ try {
+ InlongClient inlongClient = ClientUtils.getClient();
+ InlongGroup group = inlongClient.getGroup(inlongGroupId);
+ InlongGroupContext context = group.suspend();
+ if (SimpleGroupStatus.STOPPED.equals(context.getStatus())) {
Review Comment:
`SimpleGroupStatus.STOPPED` and `GroupStatus.SUSPENDED` are equivalent, the latter will convert to the former in the
manager client.
The detailed correspondence is in `org.apache.inlong.manager.common.enums.SimpleGroupStatus`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] haifxu commented on a diff in pull request #7721: [INLONG-6672][Manager] Add suspend and restart command
Posted by "haifxu (via GitHub)" <gi...@apache.org>.
haifxu commented on code in PR #7721:
URL: https://github.com/apache/inlong/pull/7721#discussion_r1151497872
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/SuspendCommand.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli;
+
+import com.beust.jcommander.Parameter;
+import com.beust.jcommander.Parameters;
+import org.apache.inlong.manager.client.api.InlongClient;
+import org.apache.inlong.manager.client.api.InlongGroup;
+import org.apache.inlong.manager.client.api.InlongGroupContext;
+import org.apache.inlong.manager.client.cli.util.ClientUtils;
+import org.apache.inlong.manager.common.enums.SimpleGroupStatus;
+
+import java.util.List;
+
+/**
+ * Suspend inlong group
+ */
+@Parameters(commandDescription = "Suspend resource by group id")
+public class SuspendCommand extends AbstractCommand {
+
+ @Parameter()
+ private List<String> params;
+
+ public SuspendCommand() {
+ super("suspend");
+ jcommander.addCommand("group", new SuspendCommand.SuspendGroup());
+ }
+
+ @Parameters(commandDescription = "Suspend the inlong group task")
+ private static class SuspendGroup extends AbstractCommandRunner {
+
+ @Parameter()
+ private List<String> params;
+
+ @Parameter(names = {"--group", "-g"}, required = true, description = "inlong group id")
+ private String inlongGroupId;
+
+ @Override
+ void run() throws Exception {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7721: [INLONG-6672][Manager] Add suspend and restart command
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7721:
URL: https://github.com/apache/inlong/pull/7721#discussion_r1151435674
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/SuspendCommand.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli;
+
+import com.beust.jcommander.Parameter;
+import com.beust.jcommander.Parameters;
+import org.apache.inlong.manager.client.api.InlongClient;
+import org.apache.inlong.manager.client.api.InlongGroup;
+import org.apache.inlong.manager.client.api.InlongGroupContext;
+import org.apache.inlong.manager.client.cli.util.ClientUtils;
+import org.apache.inlong.manager.common.enums.SimpleGroupStatus;
+
+import java.util.List;
+
+/**
+ * Suspend inlong group
+ */
+@Parameters(commandDescription = "Suspend resource by group id")
+public class SuspendCommand extends AbstractCommand {
+
+ @Parameter()
+ private List<String> params;
+
+ public SuspendCommand() {
+ super("suspend");
+ jcommander.addCommand("group", new SuspendCommand.SuspendGroup());
+ }
+
+ @Parameters(commandDescription = "Suspend the inlong group task")
+ private static class SuspendGroup extends AbstractCommandRunner {
+
+ @Parameter()
+ private List<String> params;
+
+ @Parameter(names = {"--group", "-g"}, required = true, description = "inlong group id")
+ private String inlongGroupId;
+
+ @Override
+ void run() throws Exception {
Review Comment:
Why throw an exception？
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/RestartCommand.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli;
+
+import com.beust.jcommander.Parameter;
+import com.beust.jcommander.Parameters;
+import org.apache.inlong.manager.client.api.InlongClient;
+import org.apache.inlong.manager.client.api.InlongGroup;
+import org.apache.inlong.manager.client.api.InlongGroupContext;
+import org.apache.inlong.manager.client.cli.util.ClientUtils;
+import org.apache.inlong.manager.common.enums.SimpleGroupStatus;
+
+import java.util.List;
+
+/**
+ * Restart inlong group
+ */
+@Parameters(commandDescription = "Restart resource by group id")
+public class RestartCommand extends AbstractCommand {
+
+ @Parameter()
+ private List<String> params;
+
+ public RestartCommand() {
+ super("restart");
+ jcommander.addCommand("group", new RestartCommand.RestartGroup());
+ }
+
+ @Parameters(commandDescription = "Restart the inlong group task")
+ private static class RestartGroup extends AbstractCommandRunner {
+
+ @Parameter()
+ private List<String> params;
+
+ @Parameter(names = {"--group", "-g"}, required = true, description = "inlong group id")
+ private String inlongGroupId;
+
+ @Override
+ void run() throws Exception {
Review Comment:
Why throw an exception？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #7721: [INLONG-6672][Manager] Add suspend and restart command
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #7721:
URL: https://github.com/apache/inlong/pull/7721#discussion_r1151435976
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/SuspendCommand.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli;
+
+import com.beust.jcommander.Parameter;
+import com.beust.jcommander.Parameters;
+import org.apache.inlong.manager.client.api.InlongClient;
+import org.apache.inlong.manager.client.api.InlongGroup;
+import org.apache.inlong.manager.client.api.InlongGroupContext;
+import org.apache.inlong.manager.client.cli.util.ClientUtils;
+import org.apache.inlong.manager.common.enums.SimpleGroupStatus;
+
+import java.util.List;
+
+/**
+ * Suspend inlong group
+ */
+@Parameters(commandDescription = "Suspend resource by group id")
+public class SuspendCommand extends AbstractCommand {
+
+ @Parameter()
+ private List<String> params;
+
+ public SuspendCommand() {
+ super("suspend");
+ jcommander.addCommand("group", new SuspendCommand.SuspendGroup());
+ }
+
+ @Parameters(commandDescription = "Suspend the inlong group task")
+ private static class SuspendGroup extends AbstractCommandRunner {
+
+ @Parameter()
+ private List<String> params;
+
+ @Parameter(names = {"--group", "-g"}, required = true, description = "inlong group id")
+ private String inlongGroupId;
+
+ @Override
+ void run() throws Exception {
+ try {
+ InlongClient inlongClient = ClientUtils.getClient();
+ InlongGroup group = inlongClient.getGroup(inlongGroupId);
+ InlongGroupContext context = group.suspend();
+ if (SimpleGroupStatus.STOPPED.equals(context.getStatus())) {
Review Comment:
It's better to name the command to "STOPPED" rather than "Suspend", since the status has renamed to "STOPPED".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7721: [INLONG-6672][Manager] Add suspend and restart command
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7721:
URL: https://github.com/apache/inlong/pull/7721#discussion_r1151438895
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/RestartCommand.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli;
+
+import com.beust.jcommander.Parameter;
+import com.beust.jcommander.Parameters;
+import org.apache.inlong.manager.client.api.InlongClient;
+import org.apache.inlong.manager.client.api.InlongGroup;
+import org.apache.inlong.manager.client.api.InlongGroupContext;
+import org.apache.inlong.manager.client.cli.util.ClientUtils;
+import org.apache.inlong.manager.common.enums.SimpleGroupStatus;
+
+import java.util.List;
+
+/**
+ * Restart inlong group
+ */
+@Parameters(commandDescription = "Restart resource by group id")
+public class RestartCommand extends AbstractCommand {
+
+ @Parameter()
+ private List<String> params;
+
+ public RestartCommand() {
+ super("restart");
+ jcommander.addCommand("group", new RestartCommand.RestartGroup());
+ }
+
+ @Parameters(commandDescription = "Restart the inlong group task")
+ private static class RestartGroup extends AbstractCommandRunner {
+
+ @Parameter()
+ private List<String> params;
+
+ @Parameter(names = {"--group", "-g"}, required = true, description = "inlong group id")
+ private String inlongGroupId;
+
+ @Override
+ void run() throws Exception {
+ try {
+ InlongClient inlongClient = ClientUtils.getClient();
+ InlongGroup group = inlongClient.getGroup(inlongGroupId);
+ InlongGroupContext context = group.restart();
+ if (SimpleGroupStatus.STARTED.equals(context.getStatus())) {
Review Comment:
Please add status judgment in `DeleteCommand` and `CreateCommand`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org