[GitHub] [hudi] satishkotha commented on pull request #2037: [HUDI-1226] Fix ComplexKeyGenerator for non-partitioned tables

[GitBox <gi...@apache.org>]

satishkotha commented on pull request #2037:
URL: https://github.com/apache/hudi/pull/2037#issuecomment-680279264


   > @satishkotha was it throwing an exception before this change ?
   
   From https://issues.apache.org/jira/browse/HUDI-1226, 
   1) If we pass empty string(-hoodie-conf hoodie.datasource.write.partitionpath.field=), generator returns 'default' as partitionpath
   2) if we pass delimiter alone (-hoodie-conf hoodie.datasource.write.partitionpath.field=,), it throws
   java.lang.StringIndexOutOfBoundsException: String index out of range: -1
   
   at java.lang.AbstractStringBuilder.deleteCharAt(AbstractStringBuilder.java:824)
   at java.lang.StringBuilder.deleteCharAt(StringBuilder.java:253)
   at org.apache.hudi.keygen.KeyGenUtils.getRecordPartitionPath(KeyGenUtils.java:80)
   at org.apache.hudi.keygen.ComplexKeyGenerator.getPartitionPath(ComplexKeyGenerator.java:52)
   at org.apache.hudi.keygen.BuiltinKeyGenerator.getKey(BuiltinKeyGenerator.java:75)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org